BigW Consortium Gitlab

Skip to content

M
mangoh-drivers
Commit fa806726 by David Frey
Options

Remove mangOH Red DV2 and DV3 support

mangOH Red prior to DV5 were pre-production boards. These configurations haven't been tested or maintained in a long time, so it's better to remove support for them so that users don't get the false impression that they are supported.
parent dc6e9c8c
Showing with 13 additions and 76 deletions
linux_kernel_modules/mangoh/mangoh_red.c
......@@ -9,7 +9,6 @@
#include <linux/gpio/driver.h>
#include <linux/platform_data/at24.h>
#include "lsm6ds3_platform_data.h"
#include "ltc294x-platform-data.h"
#include "bq24190-platform-data.h"
......@@ -37,8 +36,6 @@
*-----------------------------------------------------------------------------
*/
enum mangoh_red_board_rev {
MANGOH_RED_BOARD_REV_DV2,
MANGOH_RED_BOARD_REV_DV3,
MANGOH_RED_BOARD_REV_DV5,
};
......@@ -70,8 +67,6 @@ static int mangoh_red_iot_slot_release_pcm(void);
*-----------------------------------------------------------------------------
*/
static char *revision_dv2 = "dv2";
static char *revision_dv3 = "dv3";
static char *revision_dv5 = "dv5";
static char *revision = "dv5";
......@@ -155,14 +150,6 @@ static struct i2c_board_info mangoh_red_bmi160_devinfo = {
I2C_BOARD_INFO("bmi160", 0x68),
};
static struct lsm6ds3_platform_data mangoh_red_lsm6ds3_platform_data = {
.drdy_int_pin = 1,
};
static struct i2c_board_info mangoh_red_lsm6ds3_devinfo = {
I2C_BOARD_INFO("lsm6ds3", 0x6A),
.platform_data = &mangoh_red_lsm6ds3_platform_data,
};
static struct i2c_board_info mangoh_red_pressure_devinfo = {
I2C_BOARD_INFO("bmp280", 0x76),
};
......@@ -246,7 +233,6 @@ static int mangoh_red_probe(struct platform_device* pdev)
int pcm_mux_gpio;
#endif /* ENABLE_IOT_SLOT */
struct gpio_chip *gpio_expander;
struct i2c_board_info *accelerometer_board_info;
struct i2c_adapter *i2c_adapter_primary, *i2c_adapter_gpio_exp = NULL,
*i2c_adapter_batt_charger = NULL;
......@@ -350,11 +336,8 @@ static int mangoh_red_probe(struct platform_device* pdev)
* and INT2 pins respectively. It does not appear that the bmi160 driver
* makes use of these interrupt pins.
*/
accelerometer_board_info =
mangoh_red_pdata.board_rev == MANGOH_RED_BOARD_REV_DV2 ?
&mangoh_red_lsm6ds3_devinfo : &mangoh_red_bmi160_devinfo;
mangoh_red_driver_data.accelerometer =
i2c_new_device(i2c_adapter_primary, accelerometer_board_info);
i2c_new_device(i2c_adapter_primary, &mangoh_red_bmi160_devinfo);
if (!mangoh_red_driver_data.accelerometer) {
dev_err(&pdev->dev, "Accelerometer is missing\n");
return -ENODEV;
......@@ -378,17 +361,16 @@ static int mangoh_red_probe(struct platform_device* pdev)
ret = -ENODEV;
goto cleanup;
}
if (mangoh_red_pdata.board_rev != MANGOH_RED_BOARD_REV_DV3) {
/* Map the I2C ltc2942 battery gauge */
dev_dbg(&pdev->dev, "mapping ltc2942 battery gauge\n");
mangoh_red_driver_data.battery_gauge = i2c_new_device(
i2c_adapter_batt_charger,
&mangoh_red_battery_gauge_devinfo);
if (!mangoh_red_driver_data.battery_gauge) {
dev_err(&pdev->dev, "battery gauge is missing\n");
ret = -ENODEV;
goto cleanup;
}
/* Map the I2C ltc2942 battery gauge */
dev_dbg(&pdev->dev, "mapping ltc2942 battery gauge\n");
mangoh_red_driver_data.battery_gauge = i2c_new_device(
i2c_adapter_batt_charger,
&mangoh_red_battery_gauge_devinfo);
if (!mangoh_red_driver_data.battery_gauge) {
dev_err(&pdev->dev, "battery gauge is missing\n");
ret = -ENODEV;
goto cleanup;
}
/*
......@@ -415,8 +397,7 @@ static int mangoh_red_remove(struct platform_device* pdev)
dev_info(&pdev->dev, "Removing mangoh red platform device\n");
if (mangoh_red_pdata.board_rev != MANGOH_RED_BOARD_REV_DV3)
i2c_unregister_device(dd->battery_gauge);
i2c_unregister_device(dd->battery_gauge);
i2c_unregister_device(dd->battery_charger);
i2c_unregister_device(dd->pressure);
......@@ -503,11 +484,7 @@ static int __init mangoh_red_init(void)
platform_driver_register(&mangoh_red_driver);
printk(KERN_DEBUG "mangoh: registered platform driver\n");
if (strcmp(revision, revision_dv2) == 0) {
mangoh_red_pdata.board_rev = MANGOH_RED_BOARD_REV_DV2;
} else if (strcmp(revision, revision_dv3) == 0) {
mangoh_red_pdata.board_rev = MANGOH_RED_BOARD_REV_DV3;
} else if (strcmp(revision, revision_dv5) == 0) {
if (strcmp(revision, revision_dv5) == 0) {
mangoh_red_pdata.board_rev = MANGOH_RED_BOARD_REV_DV5;
} else {
pr_err("%s: Unsupported mangOH Red board revision (%s)\n",
......
linux_kernel_modules/mangoh/mangoh_red_dv2.mdef deleted 100644 → 0
cflags:
{
// Needed for lsm6ds3 platform data type definition
-I${MANGOH_ROOT}/linux_kernel_modules/lsm6ds3
-I${MANGOH_ROOT}/linux_kernel_modules/ltc294x
-I${MANGOH_ROOT}/linux_kernel_modules/bq24296
-I${MANGOH_ROOT}/linux_kernel_modules/iot_slot
}
sources:
{
mangoh_red.c
mangoh_red_mux.c
}
params:
{
revision = "dv2"
}
linux_kernel_modules/mangoh/mangoh_red_dv3.mdef deleted 100644 → 0
cflags:
{
// Needed for lsm6ds3 platform data type definition
-I${MANGOH_ROOT}/linux_kernel_modules/lsm6ds3
-I${MANGOH_ROOT}/linux_kernel_modules/ltc294x
-I${MANGOH_ROOT}/linux_kernel_modules/bq24296
-I${MANGOH_ROOT}/linux_kernel_modules/iot_slot
}
sources:
{
mangoh_red.c
mangoh_red_mux.c
}
params:
{
revision = "dv3"
}
linux_kernel_modules/mangoh/mangoh_red_dv5.mdef
cflags:
{
-DDEBUG
// Needed for lsm6ds3 platform data type definition
-I${MANGOH_ROOT}/linux_kernel_modules/lsm6ds3
-I${MANGOH_ROOT}/linux_kernel_modules/ltc294x
-I${MANGOH_ROOT}/linux_kernel_modules/bq24296
-I${MANGOH_ROOT}/linux_kernel_modules/iot_slot
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment