BigW Consortium Gitlab

Skip to content

M
mangoh-drivers
Commit 852d9948 by David Clark
Options

IoT module double free causing kernel panic

Removed kfree calls to free the slot memory. The use of devm_ calls to create the memory removes the need to call kfree.
parent 4271ac69
Showing with 0 additions and 2 deletions
linux_kernel_modules/iot_slot/iot-slot-core.c
...@@ -664,7 +664,6 @@ static int iot_slot_probe(struct platform_device *pdev) ...@@ -664,7 +664,6 @@ static int iot_slot_probe(struct platform_device *pdev)
cleanup: cleanup:
if (ret != 0) { if (ret != 0) {
kfree(slot);
slots[new_slot_index] = NULL; slots[new_slot_index] = NULL;
} }
unlock: unlock:
...@@ -702,7 +701,6 @@ static int iot_slot_remove(struct platform_device *pdev) ...@@ -702,7 +701,6 @@ static int iot_slot_remove(struct platform_device *pdev)
} }
iot_slot_release_resources(slot); iot_slot_release_resources(slot);
kfree(slot);
slots[slot_index] = NULL; slots[slot_index] = NULL;
done: done:
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment