mt7697q: Eliminate potential leak of work queue

The work queue would have been leaked in the case where the GPIO request failed because the error handling cases were in the wrong order.

mt7697q: Eliminate potential leak of work queue
6bdae894 · David Frey · David Clark · aefd9aa0 · 6bdae894
Commit 6bdae894 authored Jan 17, 2018 by David Frey Committed by David Clark Feb 21, 2018
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 3 deletions

spi.c linux_kernel_modules/mt7697q/spi.c +3 -3

No files found.
--- a/linux_kernel_modules/mt7697q/spi.c
+++ b/linux_kernel_modules/mt7697q/spi.c
@@ -186,12 +186,12 @@ static int __init mt7697spi_init(void)
 	dev_info(qinfo->dev, "%s(): '%s' initialized\n", __func__, DRVNAME);
 	return 0;

-failed_workqueue:
-	destroy_workqueue(qinfo->irq_workq);
-
 failed_gpio_req:
 	if (qinfo->gpio_pin > 0) gpio_free(qinfo->gpio_pin);

+failed_workqueue:
+	destroy_workqueue(qinfo->irq_workq);
+
 cleanup:
 	if (qinfo) kfree(qinfo);
 	return ret;