BigW Consortium Gitlab
Changes include:
- Ensure Member.add_user is not called directly when not necessary
- New GroupMember.add_users_to_group to have the same abstraction level as for Project
- Refactor Member.add_user to take a source instead of an array of members
- Fix Rubocop offenses
- Always use Project#add_user instead of project.team.add_user
- Factorize users addition as members in Member.add_users_to_source
- Make access_level a keyword argument in GroupMember.add_users_to_group and ProjectMember.add_users_to_projects
- Destroy any requester before adding them as a member
- Improve the way we handle access requesters in Member.add_user
Instead of removing the requester and creating a new member,
we now simply accepts their access request. This way, they will
receive a "access request granted" email.
- Fix error that was previously silently ignored
- Stop raising when access level is invalid in Member, let Rails validation do their work
Signed-off-by: Rémy Coutable <remy@rymai.me>
Name |
Last commit
|
Last update |
---|---|---|
.. | ||
badges | Loading commit data... | |
branches | Loading commit data... | |
commit | Loading commit data... | |
commits | Loading commit data... | |
files | Loading commit data... | |
import_export | Loading commit data... | |
issues | Loading commit data... | |
labels | Loading commit data... | |
main | Loading commit data... | |
members | Loading commit data... | |
merge_requests | Loading commit data... | |
slack_service | Loading commit data... | |
tags | Loading commit data... | |
wiki | Loading commit data... | |
branches_spec.rb | Loading commit data... | |
builds_spec.rb | Loading commit data... | |
developer_views_empty_project_instructions_spec.rb | Loading commit data... | |
edit_spec.rb | Loading commit data... | |
features_visibility_spec.rb | Loading commit data... | |
gfm_autocomplete_load_spec.rb | Loading commit data... | |
group_links_spec.rb | Loading commit data... | |
issuable_templates_spec.rb | Loading commit data... | |
pipelines_spec.rb | Loading commit data... | |
project_settings_spec.rb | Loading commit data... | |
ref_switcher_spec.rb | Loading commit data... | |
shortcuts_spec.rb | Loading commit data... | |
snippets_spec.rb | Loading commit data... |