BigW Consortium Gitlab
Changes include:
- Ensure Member.add_user is not called directly when not necessary
- New GroupMember.add_users_to_group to have the same abstraction level as for Project
- Refactor Member.add_user to take a source instead of an array of members
- Fix Rubocop offenses
- Always use Project#add_user instead of project.team.add_user
- Factorize users addition as members in Member.add_users_to_source
- Make access_level a keyword argument in GroupMember.add_users_to_group and ProjectMember.add_users_to_projects
- Destroy any requester before adding them as a member
- Improve the way we handle access requesters in Member.add_user
Instead of removing the requester and creating a new member,
we now simply accepts their access request. This way, they will
receive a "access request granted" email.
- Fix error that was previously silently ignored
- Stop raising when access level is invalid in Member, let Rails validation do their work
Signed-off-by: Rémy Coutable <remy@rymai.me>
Name |
Last commit
|
Last update |
---|---|---|
.. | ||
admin | Loading commit data... | |
atom | Loading commit data... | |
boards | Loading commit data... | |
dashboard | Loading commit data... | |
groups/members | Loading commit data... | |
issuables | Loading commit data... | |
issues | Loading commit data... | |
merge_requests | Loading commit data... | |
profiles | Loading commit data... | |
projects | Loading commit data... | |
protected_branches | Loading commit data... | |
security | Loading commit data... | |
tags | Loading commit data... | |
todos | Loading commit data... | |
users | Loading commit data... | |
calendar_spec.rb | Loading commit data... | |
ci_lint_spec.rb | Loading commit data... | |
commits_spec.rb | Loading commit data... | |
compare_spec.rb | Loading commit data... | |
container_registry_spec.rb | Loading commit data... | |
dashboard_issues_spec.rb | Loading commit data... | |
dashboard_milestones_spec.rb | Loading commit data... | |
environments_spec.rb | Loading commit data... | |
expand_collapse_diffs_spec.rb | Loading commit data... | |
gitlab_flavored_markdown_spec.rb | Loading commit data... | |
groups_spec.rb | Loading commit data... | |
help_pages_spec.rb | Loading commit data... | |
issues_spec.rb | Loading commit data... | |
login_spec.rb | Loading commit data... | |
markdown_spec.rb | Loading commit data... | |
milestone_spec.rb | Loading commit data... | |
notes_on_merge_requests_spec.rb | Loading commit data... | |
participants_autocomplete_spec.rb | Loading commit data... | |
password_reset_spec.rb | Loading commit data... | |
pipelines_settings_spec.rb | Loading commit data... | |
profile_spec.rb | Loading commit data... | |
projects_spec.rb | Loading commit data... | |
protected_branches_spec.rb | Loading commit data... | |
runners_spec.rb | Loading commit data... | |
search_spec.rb | Loading commit data... | |
signup_spec.rb | Loading commit data... | |
snippets_spec.rb | Loading commit data... | |
task_lists_spec.rb | Loading commit data... | |
triggers_spec.rb | Loading commit data... | |
u2f_spec.rb | Loading commit data... | |
unsubscribe_links_spec.rb | Loading commit data... | |
users_spec.rb | Loading commit data... | |
variables_spec.rb | Loading commit data... |