BigW Consortium Gitlab
Resolve "Build/Pipeline/Environment List Inconsistency Row Height" #### What does this MR do? * Changes generic table class from `builds` to `ci-table`. It was getting confusing using `builds` for `builds`, `pipelines`, `environments` * Sets height on builds rows for continuity #### Are there points in the code the reviewer needs to double check? Apparently you can't set `min-height` on any `table` elements but you _can_ set `height`. For some reason, even if the content within happens to start wrapping, the row height will grow instead of letting the content overlap. Which is a good thing. Just kind of weird. #### Why was this MR needed? Different row heights on builds depending on content #### Screenshots (if relevant) Before: ![Screen_Shot_2016-10-10_at_4.49.58_PM](/uploads/a4edb584f95c670f9815a8e5b1d725ee/Screen_Shot_2016-10-10_at_4.49.58_PM.png) After: ![Screen_Shot_2016-10-10_at_4.32.03_PM](/uploads/488a84b4ed292fbbb0ea7e372c017ae0/Screen_Shot_2016-10-10_at_4.32.03_PM.png) Before: ![Screen_Shot_2016-10-10_at_4.44.23_PM](/uploads/3cbcbada89d1aeb1fea35ea9b851e370/Screen_Shot_2016-10-10_at_4.44.23_PM.png) After: ![Screen_Shot_2016-10-10_at_4.42.56_PM](/uploads/0cb573670f60c7fdf54fdb027c95639f/Screen_Shot_2016-10-10_at_4.42.56_PM.png) ## What are the relevant issue numbers? Closes #23167 See merge request !6787
Name |
Last commit
|
Last update |
---|---|---|
.. | ||
assign_issues_spec.rb | Loading commit data... | |
award_spec.rb | Loading commit data... | |
cherry_pick_spec.rb | Loading commit data... | |
conflicts_spec.rb | Loading commit data... | |
create_new_mr_spec.rb | Loading commit data... | |
created_from_fork_spec.rb | Loading commit data... | |
diff_notes_resolve_spec.rb | Loading commit data... | |
diff_notes_spec.rb | Loading commit data... | |
diffs_spec.rb | Loading commit data... | |
edit_mr_spec.rb | Loading commit data... | |
filter_by_milestone_spec.rb | Loading commit data... | |
form_spec.rb | Loading commit data... | |
merge_request_versions_spec.rb | Loading commit data... | |
merge_when_build_succeeds_spec.rb | Loading commit data... | |
only_allow_merge_if_build_succeeds.rb | Loading commit data... | |
pipelines_spec.rb | Loading commit data... | |
toggle_whitespace_changes.rb | Loading commit data... | |
update_merge_requests_spec.rb | Loading commit data... | |
user_lists_merge_requests_spec.rb | Loading commit data... | |
user_uses_slash_commands_spec.rb | Loading commit data... | |
widget_deployments_spec.rb | Loading commit data... |