BigW Consortium Gitlab
Resolve "Build/Pipeline/Environment List Inconsistency Row Height" #### What does this MR do? * Changes generic table class from `builds` to `ci-table`. It was getting confusing using `builds` for `builds`, `pipelines`, `environments` * Sets height on builds rows for continuity #### Are there points in the code the reviewer needs to double check? Apparently you can't set `min-height` on any `table` elements but you _can_ set `height`. For some reason, even if the content within happens to start wrapping, the row height will grow instead of letting the content overlap. Which is a good thing. Just kind of weird. #### Why was this MR needed? Different row heights on builds depending on content #### Screenshots (if relevant) Before: ![Screen_Shot_2016-10-10_at_4.49.58_PM](/uploads/a4edb584f95c670f9815a8e5b1d725ee/Screen_Shot_2016-10-10_at_4.49.58_PM.png) After: ![Screen_Shot_2016-10-10_at_4.32.03_PM](/uploads/488a84b4ed292fbbb0ea7e372c017ae0/Screen_Shot_2016-10-10_at_4.32.03_PM.png) Before: ![Screen_Shot_2016-10-10_at_4.44.23_PM](/uploads/3cbcbada89d1aeb1fea35ea9b851e370/Screen_Shot_2016-10-10_at_4.44.23_PM.png) After: ![Screen_Shot_2016-10-10_at_4.42.56_PM](/uploads/0cb573670f60c7fdf54fdb027c95639f/Screen_Shot_2016-10-10_at_4.42.56_PM.png) ## What are the relevant issue numbers? Closes #23167 See merge request !6787
Name |
Last commit
|
Last update |
---|---|---|
.. | ||
admin | Loading commit data... | |
atom | Loading commit data... | |
boards | Loading commit data... | |
dashboard | Loading commit data... | |
groups/members | Loading commit data... | |
issuables | Loading commit data... | |
issues | Loading commit data... | |
merge_requests | Loading commit data... | |
profiles | Loading commit data... | |
projects | Loading commit data... | |
protected_branches | Loading commit data... | |
security | Loading commit data... | |
tags | Loading commit data... | |
todos | Loading commit data... | |
users | Loading commit data... | |
calendar_spec.rb | Loading commit data... | |
ci_lint_spec.rb | Loading commit data... | |
commits_spec.rb | Loading commit data... | |
compare_spec.rb | Loading commit data... | |
container_registry_spec.rb | Loading commit data... | |
dashboard_issues_spec.rb | Loading commit data... | |
dashboard_milestones_spec.rb | Loading commit data... | |
environments_spec.rb | Loading commit data... | |
expand_collapse_diffs_spec.rb | Loading commit data... | |
gitlab_flavored_markdown_spec.rb | Loading commit data... | |
groups_spec.rb | Loading commit data... | |
help_pages_spec.rb | Loading commit data... | |
issues_spec.rb | Loading commit data... | |
login_spec.rb | Loading commit data... | |
markdown_spec.rb | Loading commit data... | |
milestone_spec.rb | Loading commit data... | |
notes_on_merge_requests_spec.rb | Loading commit data... | |
participants_autocomplete_spec.rb | Loading commit data... | |
password_reset_spec.rb | Loading commit data... | |
pipelines_settings_spec.rb | Loading commit data... | |
profile_spec.rb | Loading commit data... | |
projects_spec.rb | Loading commit data... | |
protected_branches_spec.rb | Loading commit data... | |
runners_spec.rb | Loading commit data... | |
search_spec.rb | Loading commit data... | |
signup_spec.rb | Loading commit data... | |
snippets_spec.rb | Loading commit data... | |
task_lists_spec.rb | Loading commit data... | |
triggers_spec.rb | Loading commit data... | |
u2f_spec.rb | Loading commit data... | |
unsubscribe_links_spec.rb | Loading commit data... | |
users_spec.rb | Loading commit data... | |
variables_spec.rb | Loading commit data... |