- 13 Aug, 2016 1 commit
-
-
Phil Hughes authored
-
- 11 Aug, 2016 1 commit
-
-
Christopher Bartz authored
-
- 10 Aug, 2016 1 commit
-
-
Clement Ho authored
-
- 05 Aug, 2016 16 commits
-
-
Alfredo Sumaran authored
-
Alfredo Sumaran authored
-
Alfredo Sumaran authored
-
Alfredo Sumaran authored
-
Alfredo Sumaran authored
-
Alfredo Sumaran authored
-
Alfredo Sumaran authored
-
Alfredo Sumaran authored
Since there’s only one dropdown of this type we don’t need a class to create this dropdown masively.
-
Alfredo Sumaran authored
-
Alfredo Sumaran authored
We should stop passing events as a parameter since we cannot call the method programatically without faking or creating an event even when that event is not entirely required.
-
Alfredo Sumaran authored
-
Alfredo Sumaran authored
Since there are only one dropdown of each type there are no need to create a class to initialize multiple elements with the same CSS class name.
-
Alfredo Sumaran authored
-
Alfredo Sumaran authored
-
Alfredo Sumaran authored
Also updates protect branch list
-
Rik de Groot authored
* Respect parameters of each individual select, instead of the global. * Update skipped users in approver search when removed from default approvers.
-
- 04 Aug, 2016 3 commits
-
-
Annabel Dunstone authored
-
Phil Hughes authored
-
Tim Masliuchenko authored
-
- 03 Aug, 2016 1 commit
-
-
Phil Hughes authored
-
- 02 Aug, 2016 1 commit
-
-
winniehell authored
This reverts commit 1bba46d6.
-
- 01 Aug, 2016 1 commit
-
-
Douwe Maan authored
-
- 29 Jul, 2016 8 commits
-
-
Timothy Andrew authored
1. Instantiate `ProtectedBranchesAccessSelect` from `dispatcher` 2. Use `can?(user, ...)` instead of `user.can?(...)` 3. Add `DOWNTIME` notes to all migrations added in !5081. 4. Add an explicit `down` method for migrations removing the `developers_can_push` and `developers_can_merge` columns, ensuring that the columns created (on rollback) have the appropriate defaults. 5. Remove duplicate CHANGELOG entries. 6. Blank lines after guard clauses.
-
Timothy Andrew authored
1. It makes sense to reuse these constants since we had them duplicated in the previous enum implementation. This also simplifies our `check_access` implementation, because we can use `project.team.max_member_access` directly. 2. Use `accepts_nested_attributes_for` to create push/merge access levels. This was a bit fiddly to set up, but this simplifies our code by quite a large amount. We can even get rid of `ProtectedBranches::BaseService`. 3. Move API handling back into the API (previously in `ProtectedBranches::BaseService#translate_api_params`. 4. The protected branch services now return a `ProtectedBranch` rather than `true/false`. 5. Run `load_protected_branches` on-demand in the `create` action, to prevent it being called unneccessarily. 6. "Masters" is pre-selected as the default option for "Allowed to Push" and "Allowed to Merge". 7. These changes were based on a review from @rymai in !5081.
-
Timothy Andrew authored
1. Remove `master_or_greater?` and `developer_or_greater?` in favor of `max_member_access`, which is a lot nicer. 2. Remove a number of instances of `include Gitlab::Database::MigrationHelpers` in migrations that don't need this module. Also remove comments where not necessary. 3. Remove duplicate entry in CHANGELOG. 4. Move `ProtectedBranchAccessSelect` from Coffeescript to ES6. 5. Split the `set_access_levels!` method in two - one each for `merge` and `push` access levels.
-
Timothy Andrew authored
1. These versions of PhantomJS don't support `PATCH` requests, so we use a `POST` with `_method` set to `PATCH`.
-
Timothy Andrew authored
1. The model now contains this humanization data, which is the once source of truth. 2. Previously, this was being listed out in the dropdown component as well.
-
Timothy Andrew authored
1. Get the existing spec passing. 2. Add specs for all the access control options, both while creating and updating protected branches. 3. Show a flash notice when updating protected branches, primarily so the spec knows when the update is done.
-
Timothy Andrew authored
1. Reuse the same dropdown component that we used for updating these settings (`ProtectedBranchesAccessSelect`). Have it accept options for the parent container (so we can control the elements it sees) and whether or not to save changes via AJAX (we need this for update, but not create). 2. Change the "Developers" option to "Developers + Masters", which is clearer. 3. Remove `developers_can_push` and `developers_can_merge` from the model, since they're not needed anymore.
-
Timothy Andrew authored
1. Move to dropdowns instead of checkboxes. One each for "Allowed to Push" and "Allowed to Merge" 2. Refactor the `ProtectedBranches` coffeescript class into `ProtectedBranchesAccessSelect`. 3. Modify the backend to accept the new parameters.
-
- 27 Jul, 2016 3 commits
-
-
Phil Hughes authored
-
Sean McGivern authored
Pass an array of user IDs in the `skip_users` param to have them excluded from the results (unless they are explicitly included through the `current_user` or `author_id` params).
-
Alfredo Sumaran authored
-
- 26 Jul, 2016 2 commits
-
-
Connor Shea authored
-
Connor Shea authored
Instead add data attributes to a JS hook element on every import status page.
-
- 25 Jul, 2016 2 commits
-
-
Annabel Dunstone authored
-
Annabel Dunstone authored
-