- 29 Jun, 2016 1 commit
-
-
Stan Hu authored
In #19273, we saw that retrieving ProjectTeam#human_max_access for each note takes the bulk of the time when rendering certain issues or merge requests. We observe that most of the comments in an issue are typically done by the same users. This MR memoizes the max access level by user ID.
-
- 24 Jun, 2016 1 commit
-
-
Yorick Peterse authored
This commit changes the way certain documents are rendered (currently only Notes) and how documents are redacted. Previously both rendering and redacting would run on a per document basis. The result of this was that for every document we'd have to run countless queries just to figure out if we could display a set of links or not. This commit changes things around so that redacting Markdown documents is no longer tied into the html-pipeline Gem. This in turn allows it to redact multiple documents in a single pass, thus reducing the number of queries needed. In turn rendering issue/merge request notes has been adjusted to take advantage of this new setup. Instead of rendering Markdown somewhere deep down in a view the Markdown is rendered and redacted in the controller (taking the current user and all that into account). This has been done in such a way that the "markdown()" helper method can still be used on its own. This particular commit also paves the way for caching rendered HTML on object level. Right now there's an accessor method Note#note_html which is used for setting/getting the rendered HTML. Once we cache HTML on row level we can simply change this field to be a column and call a "save" whenever needed and we're pretty much done.
-
- 17 Jun, 2016 1 commit
-
-
Phil Hughes authored
-
- 14 Jun, 2016 2 commits
-
-
Rémy Coutable authored
+ Move 'Edit Project/Group' out of membership-related partial + Show the access request buttons only to logged-in users + Put the request access buttons out of in a more visible button + Improve the copy in the #remove_member_message helper Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
- 13 Jun, 2016 1 commit
-
-
Phil Hughes authored
-
- 08 Jun, 2016 1 commit
-
-
Connor Shea authored
-
- 06 Jun, 2016 3 commits
-
-
Fatih Acet authored
-
Fatih Acet authored
-
Fatih Acet authored
-
- 03 Jun, 2016 2 commits
-
-
James Lopez authored
This reverts commit 3e991230.
-
James Lopez authored
# Conflicts: # app/models/project.rb
-
- 02 Jun, 2016 1 commit
-
-
Phil Hughes authored
Closes #17214
-
- 26 May, 2016 1 commit
-
-
Yorick Peterse authored
This ensures all these calls have an author set, allowing the use of "all" mentions where possible.
-
- 21 May, 2016 1 commit
-
-
ZJ van de Weg authored
-
- 19 May, 2016 6 commits
-
-
ZJ van de Weg authored
[ci skip]
-
Phil Hughes authored
This spots bugs where the menu could be in a div that has overflow hidden on ie. diff comments
-
Phil Hughes authored
-
Phil Hughes authored
# Conflicts: # app/views/votes/_votes_block.html.haml
-
Phil Hughes authored
Correctly adds/removes awards in notes # Conflicts: # app/models/concerns/awardable.rb # app/views/projects/issues/show.html.haml # app/views/projects/merge_requests/_show.html.haml
-
Phil Hughes authored
# Conflicts: # app/assets/javascripts/awards_handler.coffee # app/assets/stylesheets/pages/notes.scss # app/helpers/issues_helper.rb # app/views/projects/notes/_note.html.haml
-
- 13 May, 2016 1 commit
-
-
Douwe Maan authored
-
- 20 Apr, 2016 1 commit
-
-
Phil Hughes authored
-
- 15 Apr, 2016 1 commit
-
-
Jacob Schatz authored
-
- 08 Apr, 2016 1 commit
-
-
Phil Hughes authored
Fixes #15049
-
- 07 Apr, 2016 1 commit
-
-
Annabel Dunstone authored
-
- 06 Apr, 2016 1 commit
-
-
Phil Hughes authored
-
- 31 Mar, 2016 2 commits
-
-
Phil Hughes authored
-
Phil Hughes authored
Created a class for note action buttons
-
- 10 Mar, 2016 1 commit
-
-
Phil Hughes authored
Unified the 'edited text' to be the same in descriptions and comments Closes #5538
-
- 29 Feb, 2016 1 commit
-
-
Alfredo Sumaran authored
-
- 20 Jan, 2016 1 commit
-
-
Rémy Coutable authored
- Replace 'rel' attributes with 'data' or 'id' attributes - Style jQuery methods chaining according to Jacob's guidelines - Rename a method
-
- 18 Nov, 2015 1 commit
-
-
Valery Sizov authored
-
- 17 Nov, 2015 1 commit
-
-
Jason Lee authored
Reverted #9820, github/task_list need a form, textarea for update.
-
- 16 Nov, 2015 1 commit
-
-
Robert Speicher authored
This reverts commit 63144cd0, reversing changes made to 8ab5df9d.
-
- 12 Nov, 2015 1 commit
-
-
Jason Lee authored
Use RJS to render edit note feature. Before: ``` Rendered projects/notes/_note.html.haml (27.9ms) Rendered projects/_zen.html.haml (0.3ms) Rendered projects/notes/_hints.html.haml (0.7ms) Rendered projects/_md_preview.html.haml (3.9ms) Rendered projects/notes/_edit_form.html.haml (6.9ms) Rendered projects/notes/_note.html.haml (17.7ms) Rendered projects/_zen.html.haml (0.3ms) Rendered projects/notes/_hints.html.haml (0.6ms) Rendered projects/_md_preview.html.haml (3.4ms) Rendered projects/notes/_edit_form.html.haml (7.0ms) ``` After: ``` Rendered projects/notes/_note.html.haml (13.8ms) Rendered projects/notes/_note.html.haml (7.1ms) Rendered projects/notes/_note.html.haml (9.5ms) Rendered projects/notes/_note.html.haml (8.5ms) ``` This change reduce at least 6ms * N ('N' - number of notes).
-
- 10 Nov, 2015 1 commit
-
-
Stan Hu authored
Fix for https://github.com/gitlabhq/gitlabhq/pull/9783
-
- 15 Oct, 2015 2 commits
-
-
Yorick Peterse authored
In these particular instances we can just use HAML tags directly. This can shave off some time spent loading issue pages, though this depends on the amount of comments being displayed. When viewing https://gitlab.com/gitlab-org/gitlab-ce/issues/2164 locally these changes reduce loading time by about 400 ms in total.
-
Yorick Peterse authored
This removes the need for running a query to find the User object again based on the supplied Email address.
-
- 14 Oct, 2015 1 commit
-
-
Douwe Maan authored
-