BigW Consortium Gitlab

  1. 20 Aug, 2016 2 commits
  2. 17 Aug, 2016 3 commits
  3. 04 Aug, 2016 1 commit
  4. 29 Jul, 2016 1 commit
    • Method for returning issues readable by a user · 002ad215
      Yorick Peterse authored
      The method Ability.issues_readable_by_user takes a list of users and an
      optional user and returns an Array of issues readable by said user. This
      method in turn is used by
      Banzai::ReferenceParser::IssueParser#nodes_visible_to_user so this
      method no longer needs to get all the available abilities just to check
      if a user has the "read_issue" ability.
      
      To test this I benchmarked an issue with 222 comments on my development
      environment. Using these changes the time spent in nodes_visible_to_user
      was reduced from around 120 ms to around 40 ms.
  5. 26 Jul, 2016 3 commits
  6. 20 Jul, 2016 2 commits
  7. 15 Jul, 2016 1 commit
  8. 05 Jul, 2016 3 commits
  9. 30 Jun, 2016 1 commit
  10. 29 Jun, 2016 1 commit
  11. 23 Jun, 2016 1 commit
  12. 16 Jun, 2016 2 commits
  13. 15 Jun, 2016 3 commits
  14. 14 Jun, 2016 4 commits
  15. 13 Jun, 2016 1 commit
  16. 10 Jun, 2016 1 commit
  17. 03 Jun, 2016 2 commits
  18. 01 Jun, 2016 1 commit
    • Refactor Participable · 580d2501
      Yorick Peterse authored
      There are several changes to this module:
      
      1. The use of an explicit stack in Participable#participants
      2. Proc behaviour has been changed
      3. Batch permissions checking
      
      == Explicit Stack
      
      Participable#participants no longer uses recursion to process "self" and
      all child objects, instead it uses an Array and processes objects in
      breadth-first order. This allows us to for example create a single
      Gitlab::ReferenceExtractor instance and pass this to any Procs. Re-using
      a ReferenceExtractor removes the need for running potentially many SQL
      queries every time a Proc is called on a new object.
      
      == Proc Behaviour Changed
      
      Previously a Proc in Participable was expected to return an Array of
      User instances. This has been changed and instead it's now expected that
      a Proc modifies the Gitlab::ReferenceExtractor passed to it. The return
      value of the Proc is ignored.
      
      == Permissions Checking
      
      The method Participable#participants uses
      Ability.users_that_can_read_project to check if the returned users have
      access to the project of "self" _without_ running multiple SQL queries
      for every user.
  19. 30 May, 2016 1 commit
  20. 22 May, 2016 1 commit
  21. 14 May, 2016 3 commits
  22. 13 May, 2016 1 commit
  23. 12 May, 2016 1 commit