BigW Consortium Gitlab
Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
G
gitlab-ce
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
Forest Godfrey
gitlab-ce
Commits
86cf9dd2
Commit
86cf9dd2
authored
May 30, 2016
by
Grzegorz Bizon
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Enable Lint/LiteralInCondition rubocop cop
Checks of literals used in conditions. See #17478
parent
43c35b0f
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
10 additions
and
12 deletions
+10
-12
.rubocop.yml
.rubocop.yml
+1
-1
ability.rb
app/models/ability.rb
+6
-7
irker_service.rb
app/models/project_services/irker_service.rb
+1
-1
pull_request_formatter.rb
lib/gitlab/github_import/pull_request_formatter.rb
+2
-3
No files found.
.rubocop.yml
View file @
86cf9dd2
...
...
@@ -878,7 +878,7 @@ Lint/InvalidCharacterLiteral:
# Checks of literals used in conditions.
Lint/LiteralInCondition
:
Enabled
:
fals
e
Enabled
:
tru
e
# Checks for literals used in interpolation.
Lint/LiteralInInterpolation
:
...
...
app/models/ability.rb
View file @
86cf9dd2
...
...
@@ -25,18 +25,17 @@ class Ability
# List of possible abilities for anonymous user
def
anonymous_abilities
(
user
,
subject
)
case
true
when
subject
.
is_a?
(
PersonalSnippet
)
if
subject
.
is_a?
(
PersonalSnippet
)
anonymous_personal_snippet_abilities
(
subject
)
when
subject
.
is_a?
(
ProjectSnippet
)
elsif
subject
.
is_a?
(
ProjectSnippet
)
anonymous_project_snippet_abilities
(
subject
)
when
subject
.
is_a?
(
CommitStatus
)
elsif
subject
.
is_a?
(
CommitStatus
)
anonymous_commit_status_abilities
(
subject
)
when
subject
.
is_a?
(
Project
)
||
subject
.
respond_to?
(
:project
)
elsif
subject
.
is_a?
(
Project
)
||
subject
.
respond_to?
(
:project
)
anonymous_project_abilities
(
subject
)
when
subject
.
is_a?
(
Group
)
||
subject
.
respond_to?
(
:group
)
elsif
subject
.
is_a?
(
Group
)
||
subject
.
respond_to?
(
:group
)
anonymous_group_abilities
(
subject
)
when
subject
.
is_a?
(
User
)
elsif
subject
.
is_a?
(
User
)
anonymous_user_abilities
else
[]
...
...
app/models/project_services/irker_service.rb
View file @
86cf9dd2
...
...
@@ -70,7 +70,7 @@ class IrkerService < Service
private
def
get_channels
return
true
unless
:
activated?
return
true
unless
activated?
return
true
if
recipients
.
nil?
||
recipients
.
empty?
map_recipients
...
...
lib/gitlab/github_import/pull_request_formatter.rb
View file @
86cf9dd2
...
...
@@ -79,10 +79,9 @@ module Gitlab
end
def
state
@state
||=
case
true
when
raw_data
.
state
==
'closed'
&&
raw_data
.
merged_at
.
present?
@state
||=
if
raw_data
.
state
==
'closed'
&&
raw_data
.
merged_at
.
present?
'merged'
when
raw_data
.
state
==
'closed'
elsif
raw_data
.
state
==
'closed'
'closed'
else
'opened'
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment