- 05 Jul, 2017 1 commit
-
-
Douwe Maan authored
-
- 29 Jun, 2017 1 commit
-
-
Taurie Davis authored
-
- 06 Jun, 2017 1 commit
-
-
Bryce Johnson authored
-
- 12 May, 2017 1 commit
-
-
Douwe Maan authored
-
- 09 Feb, 2017 1 commit
-
-
Felipe Artur authored
-
- 08 Feb, 2017 1 commit
-
-
Nur Rony authored
-
- 07 Feb, 2017 1 commit
-
-
Annabel Dunstone Gray authored
-
- 27 Jan, 2017 2 commits
-
-
Oswaldo Ferreira authored
-
Oswaldo Ferreira authored
-
- 31 Dec, 2016 1 commit
-
-
Kushal Pandya authored
-
- 15 Dec, 2016 1 commit
-
-
Douwe Maan authored
Fix missing Note access checks in by moving Note#search to updated NoteFinder Split from !2024 to partially solve https://gitlab.com/gitlab-org/gitlab-ce/issues/23867 ## Which fixes are in this MR?
- Potentially untested - No test coverage - Test coverage of some sort exists (a test failed when error raised) - Test coverage of return value (a test failed when nil used) - Permissions check tested ### Note lookup without access check - [x] app/finders/notes_finder.rb:13 :download_code check - [x] app/finders/notes_finder.rb:19 `SnippetsFinder` - [x] app/models/note.rb:121 [`Issue#visible_to_user`] - [x] lib/gitlab/project_search_results.rb:113 - This is the only use of `app/models/note.rb:121` above, but importantly has no access checks at all. This means it leaks MR comments and snippets when those features are `team-only` in addition to the issue comments which would be fixed by `app/models/note.rb:121`. - It is only called from SearchController where `can?(current_user, :download_code, @project)` is checked, so commit comments are not leaked. ### Previous discussions - [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#b915c5267a63628b0bafd23d37792ae73ceae272_13_13 `: download_code` check on commit - [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#b915c5267a63628b0bafd23d37792ae73ceae272_19_19 `SnippetsFinder` should be used - `SnippetsFinder` should check if the snippets feature is enabled -> https://gitlab.com/gitlab-org/gitlab-ce/issues/25223 ### Acceptance criteria met? - [x] Tests added for new code - [x] TODO comments removed - [x] Squashed and removed skipped tests - [x] Changelog entry - [ ] State Gitlab versions affected and issue severity in description - [ ] Create technical debt issue for NotesFinder. - Either split into `NotesFinder::ForTarget` and `NotesFinder::Search` or consider object per notable type such as `NotesFinder::OnIssue`. For the first option could create `NotesFinder::Base` which is either inherited from or which can be included in the other two. - Avoid case statement anti-pattern in this finder with use of `NotesFinder::OnCommit` etc. Consider something on the finder for this? `Model.finder(user, project)` - Move `inc_author` to the controller, and implement `related_notes` to replace `non_diff_notes`/`mr_and_commit_notes` See merge request !2035
-
- 14 Dec, 2016 1 commit
-
-
Alfredo Sumaran authored
This fixes the case when the user wants to add a label. The user has to use the dropdown’s filter input to look for a label and click it in order to see the bug. Step to reproduce - Select at least two issues, one label should be present in all issues, other label should be present in at least one. - On the label dropdown: Deselect label that is present in all issues, look for another issue using the filter input and click it. - Click on `Update issues` Before: Unmarked label were kept on selected issues. Now: Unmarked label is removed from selected issues
-
- 29 Nov, 2016 1 commit
-
-
Grzegorz Bizon authored
-
- 18 Nov, 2016 1 commit
-
-
Douwe Maan authored
-
- 19 Oct, 2016 2 commits
-
-
Douglas Barbosa Alexandre authored
-
Douglas Barbosa Alexandre authored
-
- 08 Sep, 2016 1 commit
-
-
Dmitriy Zaporozhets authored
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
- 07 Sep, 2016 1 commit
-
-
Luke Bennett authored
Rearranged datetime created line Added `avatar_class` option to `link_to_member` so it can be hidden Made snippet title font heavier Added file title bar Hidden unneeded info from xs screens Added visibility icon Reveal file-actions on xs screens Added comments icon to snippets list items Refactored no-comments declaration into framework stylesheet Final touch ups Fixed snippets_spec
-
- 03 Jun, 2016 3 commits
-
-
Kamil Trzcinski authored
-
James Lopez authored
This reverts commit 3e991230.
-
James Lopez authored
# Conflicts: # app/models/project.rb
-
- 24 May, 2016 1 commit
-
-
Connor Shea authored
Previously if an issue had an emoji for its name it would be unclickable. Similarly, links were rendered inline if the title was something like “Fixes a bug with https://google.com”. This confused some users, so it’s removed. On the issue/MR page itself, the formatting is preserved. This only effects index pages. This is also ever so slightly more performant :) This fixes #17614 and #17230.
-
- 18 May, 2016 1 commit
-
-
ZJ van de Weg authored
-
- 11 May, 2016 1 commit
-
-
Zeger-Jan van de Weg authored
-
- 09 May, 2016 1 commit
-
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
- 06 May, 2016 1 commit
-
-
Zeger-Jan van de Weg authored
-
- 14 Apr, 2016 1 commit
-
-
theoretick authored
Fixes Issue #14431
-
- 13 Apr, 2016 1 commit
-
-
Kamil Trzcinski authored
-
- 20 Mar, 2016 1 commit
-
-
Arinde Eniola authored
-
- 18 Mar, 2016 1 commit
-
-
Dmitriy Zaporozhets authored
* Introduce 2 color links: black and blue * Use black color link for UI elements like lists * Refactor lists to use .title nested under li * Make all lists (events, todos, activity, projects etc) use style * List colorschema is now 333 for links and 555 for text Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
- 01 Mar, 2016 3 commits
-
-
Phil Hughes authored
-
Phil Hughes authored
-
Phil Hughes authored
Closes #9082
-
- 26 Feb, 2016 1 commit
-
-
Dmitriy Zaporozhets authored
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
- 22 Feb, 2016 1 commit
-
-
Phil Hughes authored
Removed up/down vote icons from merge requests. Was missed from d8069bd8
-
- 17 Feb, 2016 1 commit
-
-
Douglas Barbosa Alexandre authored
-
- 04 Feb, 2016 1 commit
-
-
Rémy Coutable authored
You can set type: :merge_request to create a link to merge request lists instead of issues list. Accept both Symbol & String as type argument for the link_to_label helper
-
- 18 Dec, 2015 1 commit
-
-
Douwe Maan authored
-
- 10 Dec, 2015 1 commit
-
-
Achilleas Pipinellis authored
Now that GitLab CI exposes the status of each MR in the MR page it seems "redundant" to have an extra icon next to the CI statuses.
-
- 08 Dec, 2015 1 commit
-
-
Douwe Maan authored
-