BigW Consortium Gitlab

  1. 05 Jul, 2017 1 commit
  2. 29 Jun, 2017 1 commit
  3. 06 Jun, 2017 1 commit
  4. 12 May, 2017 1 commit
  5. 09 Feb, 2017 1 commit
  6. 08 Feb, 2017 1 commit
  7. 07 Feb, 2017 1 commit
  8. 27 Jan, 2017 2 commits
  9. 31 Dec, 2016 1 commit
  10. 15 Dec, 2016 1 commit
    • Merge branch 'jej-note-search-uses-finder' into 'security' · 12db4cc0
      Douwe Maan authored
      Fix missing Note access checks in by moving Note#search to updated NoteFinder
      
      Split from !2024 to partially solve https://gitlab.com/gitlab-org/gitlab-ce/issues/23867
      
      ## Which fixes are in this MR?
      
      :warning: - Potentially untested  
      :bomb: - No test coverage  
      :traffic_light: - Test coverage of some sort exists (a test failed when error raised)  
      :vertical_traffic_light: - Test coverage of return value (a test failed when nil used)  
      :white_check_mark: - Permissions check tested
      
      ### Note lookup without access check
      
      - [x] :white_check_mark: app/finders/notes_finder.rb:13 :download_code check
      - [x] :white_check_mark: app/finders/notes_finder.rb:19 `SnippetsFinder`
      - [x] :white_check_mark: app/models/note.rb:121 [`Issue#visible_to_user`]
      - [x] :white_check_mark: lib/gitlab/project_search_results.rb:113
        - This is the only use of `app/models/note.rb:121` above, but importantly has no access checks at all. This means it leaks MR comments and snippets when those features are `team-only` in addition to the issue comments which would be fixed by `app/models/note.rb:121`.
        - It is only called from SearchController where `can?(current_user, :download_code, @project)` is checked, so commit comments are not leaked.
      
      ### Previous discussions
      - [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#b915c5267a63628b0bafd23d37792ae73ceae272_13_13 `: download_code` check on commit
      - [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#b915c5267a63628b0bafd23d37792ae73ceae272_19_19 `SnippetsFinder` should be used
        - `SnippetsFinder` should check if the snippets feature is enabled -> https://gitlab.com/gitlab-org/gitlab-ce/issues/25223
      
      ###  Acceptance criteria met?
      - [x] Tests added for new code
      - [x] TODO comments removed
      - [x] Squashed and removed skipped tests
      - [x] Changelog entry
      - [ ] State Gitlab versions affected and issue severity in description
      - [ ] Create technical debt issue for NotesFinder.
        - Either split into `NotesFinder::ForTarget` and `NotesFinder::Search` or consider object per notable type such as `NotesFinder::OnIssue`. For the first option could create `NotesFinder::Base` which is either inherited from or which can be included in the other two.
        - Avoid case statement anti-pattern in this finder with use of `NotesFinder::OnCommit` etc. Consider something on the finder for this? `Model.finder(user, project)`
        - Move `inc_author` to the controller, and implement `related_notes` to replace `non_diff_notes`/`mr_and_commit_notes`
      
      See merge request !2035
  11. 14 Dec, 2016 1 commit
    • Improve issuable's bulk assignment implementation · 262fc28a
      Alfredo Sumaran authored
      This fixes the case when the user wants to add a label. The user has to use the dropdown’s filter input to look for a label and click it in order to see the bug.
      
      Step to reproduce
      
      - Select at least two issues, one label should be present in all issues, other label should be present in at least one.
      
      - On the label dropdown: Deselect label that is present in all issues, look for another issue using the filter input and click it.
      
      - Click on `Update issues`
      
      Before: Unmarked label were kept on selected issues.
      Now: Unmarked label is removed from selected issues
  12. 29 Nov, 2016 1 commit
  13. 18 Nov, 2016 1 commit
  14. 19 Oct, 2016 2 commits
  15. 08 Sep, 2016 1 commit
  16. 07 Sep, 2016 1 commit
    • Reordered dropdown options · 56461e0c
      Luke Bennett authored
      Rearranged datetime created line
      
      Added `avatar_class` option to `link_to_member` so it can be hidden
      
      Made snippet title font heavier
      
      Added file title  bar
      
      Hidden unneeded info from xs screens
      
      Added visibility icon
      
      Reveal file-actions on xs screens
      
      Added comments icon to snippets list items
      
      Refactored no-comments declaration into framework stylesheet
      
      Final touch ups
      
      Fixed snippets_spec
  17. 03 Jun, 2016 3 commits
  18. 24 May, 2016 1 commit
    • Replace `link_to_gfm` with `link_to` in merge request and issue titles. · 77a1565c
      Connor Shea authored
      Previously if an issue had an emoji for its name it would be unclickable. Similarly, links were rendered inline if the title was something like “Fixes a bug with https://google.com”. This confused some users, so it’s removed.
      
      On the issue/MR page itself, the formatting is preserved. This only effects index pages.
      
      This is also ever so slightly more performant :)
      
      This fixes #17614 and #17230.
  19. 18 May, 2016 1 commit
  20. 11 May, 2016 1 commit
  21. 09 May, 2016 1 commit
  22. 06 May, 2016 1 commit
  23. 14 Apr, 2016 1 commit
  24. 13 Apr, 2016 1 commit
  25. 20 Mar, 2016 1 commit
  26. 18 Mar, 2016 1 commit
  27. 01 Mar, 2016 3 commits
  28. 26 Feb, 2016 1 commit
  29. 22 Feb, 2016 1 commit
  30. 17 Feb, 2016 1 commit
  31. 04 Feb, 2016 1 commit
  32. 18 Dec, 2015 1 commit
  33. 10 Dec, 2015 1 commit
  34. 08 Dec, 2015 1 commit