Replace `link_to_gfm` with `link_to` in merge request and issue titles.

Previously if an issue had an emoji for its name it would be unclickable. Similarly, links were rendered inline if the title was something like “Fixes a bug with https://google.com”. This confused some users, so it’s removed. On the issue/MR page itself, the formatting is preserved. This only effects index pages. This is also ever so slightly more performant :) This fixes #17614 and #17230.

Replace `link_to_gfm` with `link_to` in merge request and issue titles.
77a1565c · Connor Shea · a9b431c5 · 77a1565c · 77a1565c
Unverified Commit 77a1565c authored May 24, 2016 by Connor Shea
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 2 deletions

_issue.html.haml app/views/projects/issues/_issue.html.haml +1 -1

_merge_request.html.haml app/views/projects/merge_requests/_merge_request.html.haml +1 -1

No files found.
--- a/app/views/projects/issues/_issue.html.haml
+++ b/app/views/projects/issues/_issue.html.haml
@@ -6,7 +6,7 @@
  .issue-title.title
    %span.issue-title-text
      = confidential_icon(issue)
-      = link_to_gfm issue.title, issue_path(issue)
+      = link_to issue.title, issue_path(issue)
    %ul.controls
      - if issue.closed?
        %li

--- a/app/views/projects/merge_requests/_merge_request.html.haml
+++ b/app/views/projects/merge_requests/_merge_request.html.haml
 %li{ class: mr_css_classes(merge_request) }
  .merge-request-title.title
    %span.merge-request-title-text
-      = link_to_gfm merge_request.title, merge_request_path(merge_request)
+      = link_to merge_request.title, merge_request_path(merge_request)
    %ul.controls
      - if merge_request.merged?
        %li