- 29 May, 2017 1 commit
-
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
- 25 May, 2017 2 commits
-
-
Nick Thomas authored
-
Alexander Randa authored
* implemented logging of project and system web hooks * implemented UI for user area (project hooks) * implemented UI for admin area (system hooks) * implemented retry of logged webhook * NOT imeplemented log remover
-
- 24 May, 2017 2 commits
-
-
Alexis Reigel authored
-
Douwe Maan authored
-
- 23 May, 2017 1 commit
-
-
Douwe Maan authored
-
- 22 May, 2017 2 commits
-
-
Kamil Trzcinski authored
- Do not care about error when creating index on PostgreSQL - Test against PostgreSQL 9.2
-
Kamil Trzcinski authored
> Mysql2::Error: Table 'ci_builds' is specified twice, both as a target for 'UPDATE' and as a separate source for data: UPDATE `ci_builds` SET `retried` = ((SELECT MAX(ci_builds2.id) Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/32647
-
- 19 May, 2017 6 commits
-
-
Bob Van Landuyt authored
-
Bob Van Landuyt authored
-
Bob Van Landuyt authored
-
Lin Jen-Shin authored
Closes #32469
-
Bob Van Landuyt authored
-
Bob Van Landuyt authored
-
- 18 May, 2017 1 commit
-
-
Valery Sizov authored
-
- 17 May, 2017 5 commits
-
-
Yorick Peterse authored
The procedure for migrating issue assignees is invoked on both an INSERT and UPDATE. This means it will fail for INSERTs because OLD is set to NULL in this case.
-
Z.J. van de Weg authored
-
Yorick Peterse authored
This column is used when refreshing authorizations and without the index leads to a sequence scan being performed on this table.
-
Yorick Peterse authored
This migration will take all nested groups and convert them into regular groups, ensuring that members of any parent groups still have access to the child group. This migration relies on code external to it as copying all of this over involves hundreds of lines of code depending on all sorts of methods, making this practically impossible to do right.
-
Yorick Peterse authored
This commit introduces the usage of Common Table Expressions (CTEs) to efficiently retrieve nested group hierarchies, without having to rely on the "routes" table (which is an _incredibly_ inefficient way of getting the data). This requires a patch to ActiveRecord (found in the added initializer) to work properly as ActiveRecord doesn't support WITH statements properly out of the box. Unfortunately MySQL provides no efficient way of getting nested groups. For example, the old routes setup could easily take 5-10 seconds depending on the amount of "routes" in a database. Providing vastly different logic for both MySQL and PostgreSQL will negatively impact the development process. Because of this the various nested groups related methods return empty relations when used in combination with MySQL. For project authorizations the logic is split up into two classes: * Gitlab::ProjectAuthorizations::WithNestedGroups * Gitlab::ProjectAuthorizations::WithoutNestedGroups Both classes get the fresh project authorizations (= as they should be in the "project_authorizations" table), including nested groups if PostgreSQL is used. The logic of these two classes is quite different apart from their public interface. This complicates development a bit, but unfortunately there is no way around this. This commit also introduces Gitlab::GroupHierarchy. This class can be used to get the ancestors and descendants of a base relation, or both by using a UNION. This in turn is used by methods such as: * Namespace#ancestors * Namespace#descendants * User#all_expanded_groups Again this class relies on CTEs and thus only works on PostgreSQL. The Namespace methods will return an empty relation when MySQL is used, while User#all_expanded_groups will return only the groups a user is a direct member of. Performance wise the impact is quite large. For example, on GitLab.com Namespace#descendants used to take around 580 ms to retrieve data for a particular user. Using CTEs we are able to reduce this down to roughly 1 millisecond, returning the exact same data. == On The Fly Refreshing Refreshing of authorizations on the fly (= when users.authorized_projects_populated was not set) is removed with this commit. This simplifies the code, and ensures any queries used for authorizations are not mutated because they are executed in a Rails scope (e.g. Project.visible_to_user). This commit includes a migration to schedule refreshing authorizations for all users, ensuring all of them have their authorizations in place. Said migration schedules users in batches of 5000, with 5 minutes between every batch to smear the load around a bit. == Spec Changes This commit also introduces some changes to various specs. For example, some specs for ProjectTeam assumed that creating a personal project would _not_ lead to the owner having access, which is incorrect. Because we also no longer refresh authorizations on the fly for new users some code had to be added to the "empty_project" factory. This chunk of code ensures that the owner's permissions are refreshed after creating the project, something that is normally done in Projects::CreateService.
-
- 16 May, 2017 2 commits
-
-
Valery Sizov authored
-
Douwe Maan authored
Rename `build_events` to `job_events` Closes #31620 See merge request !11287
-
- 15 May, 2017 7 commits
-
-
Douwe Maan authored
This reverts merge request !11287
-
Bob Van Landuyt authored
-
Lin Jen-Shin authored
-
Lin Jen-Shin authored
-
Z.J. van de Weg authored
Set to nullify, so the settings remain if the user is deleted. Fixes gitlab-org/gitlab-ce#31932
-
Lin Jen-Shin authored
-
Lin Jen-Shin authored
-
- 12 May, 2017 1 commit
-
-
Gabriel Mazetto authored
-
- 11 May, 2017 4 commits
-
-
Z.J. van de Weg authored
Enforced by the database, and no callbacks need to be called. Combined with 7b9b2c6099 and 294a8b8a6d this resolves gitlab-org/gitlab-ce#31799
-
Z.J. van de Weg authored
Variables shouldn't exist without a project, so a foreign key was added with CASCADE'ing effects.
-
Z.J. van de Weg authored
To be more specific; key, and project_id. If either of these is NULL its wrong, because: 1. storing a key value pair without key is just plain wrong 2. all variables should belong to a project Non of these cases existed on the staging database.
-
Douwe Maan authored
-
- 10 May, 2017 5 commits
-
-
Rémy Coutable authored
Use the EnforcedStyleForMultiline: no_comma option. Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Toon Claes authored
Since this is a cleanup, ran by a post-deploy, there is no need to lookup the admin to run the cleanup.
-
Toon Claes authored
Destroying projects can be very time consuming. So instead of destroying them in the post-deploy, just schedule them and make Sidekiq do the hard work. They are scheduled in batches of 5000 records. This way the number of database requests is limited while also the amount data read to memory is limited.
-
Toon Claes authored
-
Toon Claes authored
There are many projects in `pending_delete` state, this post-deploy migration cleans them up. The script is based on https://gitlab.com/gitlab-org/gitlab-ce/snippets/1648654 and https://gitlab.com/gitlab-org/gitlab-ce/snippets/1611429. The use of these scripts were described in https://gitlab.com/gitlab-com/infrastructure/issues/888.
-
- 09 May, 2017 1 commit
-
-
Kamil Trzcinski authored
-