Prevent NULL values on ci_variables columns

To be more specific; key, and project_id. If either of these is NULL its wrong, because: 1. storing a key value pair without key is just plain wrong 2. all variables should belong to a project Non of these cases existed on the staging database.

Prevent NULL values on ci_variables columns
38388338 · Z.J. van de Weg · 1ccf101e · 38388338
Commit 38388338 authored May 08, 2017 by Z.J. van de Weg
Hide whitespace changes
Inline Side-by-side

Showing with 12 additions and 0 deletions

20170508153950_add_not_null_contraints_to_ci_variables.rb ...20170508153950_add_not_null_contraints_to_ci_variables.rb +12 -0

No files found.
--- a/db/post_migrate/20170508153950_add_not_null_contraints_to_ci_variables.rb
+++ b/db/post_migrate/20170508153950_add_not_null_contraints_to_ci_variables.rb
+class AddNotNullContraintsToCiVariables < ActiveRecord::Migration
+  DOWNTIME = false
+
+  def up
+    change_column(:ci_variables, :key, :string, null: false)
+    change_column(:ci_variables, :project_id, :integer, null: false)
+  end
+
+  def down
+    # no op
+  end
+end