- 17 Aug, 2016 2 commits
-
-
Douglas Barbosa Alexandre authored
-
Paco Guzman authored
Use just SQL to check is a user can admin_issue on a project Tradeoff - we duplicate how we check admin_issue in a SQL relation in the Ability class
-
- 10 Aug, 2016 2 commits
-
-
Rémy Coutable authored
Also, mutualize AccessRequests and Members endpoints for Group & Project. New API documentation for the AccessRequests endpoints. Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Stan Hu authored
Instead of redirecting from the project service to the service and back to the model, put all destruction code in the service. Also removes a possible source of failure where run_after_commit may not destroy the project.
-
- 09 Aug, 2016 1 commit
-
-
Stan Hu authored
This is in preparation to address the DB load caused by the counting in gitlab-com/infrastructure#303.
-
- 04 Aug, 2016 2 commits
-
-
tiagonbotelho authored
-
James Lopez authored
-
- 02 Aug, 2016 1 commit
-
-
tiagonbotelho authored
developer cannot push to protected branch when project is empty or he has not been granted permission to do so
-
- 01 Aug, 2016 1 commit
-
-
James Lopez authored
squashed - fixed label and milestone association problems, updated specs and refactored reader class a bit
-
- 29 Jul, 2016 1 commit
-
-
Timothy Andrew authored
1. Remove `Project#developers_can_push_to_protected_branch?` since it isn't used anymore. 2. Remove `Project#developers_can_merge_to_protected_branch?` since it isn't used anymore.
-
- 28 Jul, 2016 1 commit
-
-
Stan Hu authored
-
- 27 Jul, 2016 1 commit
-
-
Douglas Barbosa Alexandre authored
-
- 26 Jul, 2016 1 commit
-
-
Alejandro Rodríguez authored
-
- 23 Jul, 2016 1 commit
-
-
Stan Hu authored
Helping to diagnose #20178
-
- 21 Jul, 2016 1 commit
-
- 20 Jul, 2016 8 commits
-
-
Alejandro Rodríguez authored
Currently, even when searching for all authorized issues of *one* project, we run the `Users#authorized_projects` query (which can be rather slow). This update checks if we are handling issues of just one project and does the authorization check locally. It does have the downside of basically repeating the logic of `Users#authorized_projects` on `Project#authorized_for_user`.
-
Lin Jen-Shin authored
This version of MySQL doesn't yet support 'LIMIT & IN/ALL/ANY/SOME subquery' Oh well.
-
Lin Jen-Shin authored
So we no longer join anything, just find the latest pipeline and load builds from there to avoid mixing builds. Thanks Kamil for the help and tests.
-
Kamil Trzcinski authored
-
Lin Jen-Shin authored
-
Kamil Trzcinski authored
-
Lin Jen-Shin authored
also added a test for checking this.
-
- 19 Jul, 2016 4 commits
-
-
Eugene Howe authored
* This method previously iterated over all services in a project. Now it will directly query the ExternalWikiService for the project and filter by active state. * The presence of an external wiki is also cached * When an external wiki is added or removed, the cached value is updated
-
Lin Jen-Shin authored
This was extracted from !5142 and implementing part of #4255. We split it from !5142 because we want to ship it in 8.10 while !5142 was not ready yet.
- 18 Jul, 2016 3 commits
-
-
Rémy Coutable authored
This reverts commit 530f5158. See !4892. Signed-off-by: Rémy Coutable <remy@rymai.me>
-
James Lopez authored
-
Stan Hu authored
preventing settings from being saved
-
- 15 Jul, 2016 1 commit
-
-
Kamil Trzcinski authored
-
- 13 Jul, 2016 5 commits
-
-
Robert Speicher authored
This reverts commit 9ca633eb, reversing changes made to fb229bbf.
-
James Lopez authored
-
James Lopez authored
-
Mathias Vestergaard authored
- Cherry-picked from `mvestergaard:branch-protection-dev-merge` - https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4220
-
James Lopez authored
-
- 12 Jul, 2016 1 commit
-
-
James Lopez authored
fixes a few issues to do with import_url not being saved correctly for imports. This should prevent the import_data to be created when it should not and output an error properly validating before creating it.
-
- 07 Jul, 2016 2 commits
-
-
Timothy Andrew authored
1. The `open_branches` method is used to provide a list of branches while creating a protected branch. 2. It makes sense to include branches which are matched by one or more wildcard protected branches, since the user might want to make exact protected branches from these as well. 3. This also provides a large performance improvement. On my machine, in a project with 5000 branches and 2000 protected branches, the `ProtectedBranches#index` page went from a 40 seconds load time to 4 seconds (10x speedup).
- 05 Jul, 2016 1 commit
-
-
Robert Speicher authored
`avatar.present?` goes through CarrierWave, and checks that the file exists on disk and checks its filesize. Because we're hitting the disk, this adds extra overhead to something where the worst-case scenario is rendering a broken image. Instead, we now just check that the _database attribute_ is present, which is good enough for our purposes. See https://gitlab.com/gitlab-org/gitlab-ce/issues/19273
-