BigW Consortium Gitlab
Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
G
gitlab-ce
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
Forest Godfrey
gitlab-ce
Commits
5e0669e0
Commit
5e0669e0
authored
Jul 21, 2016
by
Lin Jen-Shin
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Since it's too hard to use JOIN with Rails... feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347#note_13204564
parent
e5b05fe8
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
7 additions
and
7 deletions
+7
-7
project.rb
app/models/project.rb
+7
-7
No files found.
app/models/project.rb
View file @
5e0669e0
...
...
@@ -431,13 +431,13 @@ class Project < ActiveRecord::Base
# ref can't be HEAD, can only be branch/tag name or SHA
def
latest_successful_builds_for
(
ref
=
default_branch
)
pipeline
=
pipelines
.
latest_successful_for
(
ref
).
to_sql
join_sql
=
"INNER JOIN (
#{
pipeline
}
) pipelines"
+
" ON pipelines.id =
#{
Ci
::
Build
.
quoted_table_name
}
.commit_id"
builds
.
joins
(
join_sql
)
.
latest
.
with_artifacts
# TODO: Whenever we dropped support for MySQL, we could change to:
# pipeline = pipelines.latest_successful_for(ref)
# builds.where(pipeline: pipeline).latest.with_artifacts
latest_pipeline
=
pipelines
.
latest_successful_for
(
ref
).
first
if
latest_pipeline
latest_pipeline
.
builds
.
latest
.
with_artifacts
else
builds
.
none
end
end
def
merge_base_commit
(
first_commit_id
,
second_commit_id
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment