BigW Consortium Gitlab

  1. 01 Nov, 2016 1 commit
  2. 28 Oct, 2016 2 commits
  3. 24 Oct, 2016 2 commits
    • Implement review comments from @DouweM. · b803bc7b
      Timothy Andrew authored
    • Fix branch protection API. · f79f3a1d
      Timothy Andrew authored
      1. Previously, we were not removing existing access levels before
         creating new ones. This is not a problem for EE, but _is_ for CE,
         since we restrict the number of access levels in CE to 1.
      
      2. The correct approach is:
      
          CE -> delete all access levels before updating a protected branch
          EE -> delete developer access levels if "developers_can_{merge,push}" is switched off
      
      3. The dispatch is performed by checking if a "length: 1" validation is
         present on the access levels or not.
      
      4. Another source of problems was that we didn't put multiple queries in
         a transaction. If the `destroy_all` passes, but the `update` fails,
         we should have a rollback.
      
      5. Modifying the API to provide users direct access to CRUD access
         levels will make things a lot simpler.
      
      6. Create `create/update` services separately for this API, which
         perform the necessary data translation, before calling the regular
         `create/update` services. The translation code was getting too large
         for the API endpoint itself, so this move makes sense.
  4. 20 Oct, 2016 1 commit
    • Differentiate the expire from leave event · 9124310f
      Callum Dryden authored
      At the moment we cannot see weather a user left a project due to their
      membership expiring of if they themselves opted to leave the project.
      This adds a new event type that allows us to make this differentiation.
      Note that is not really feasable to go back and reliably fix up the
      previous events. As a result the events for previous expire removals
      will remain the same however events of this nature going forward will be
      correctly represented.
  5. 19 Oct, 2016 8 commits
  6. 18 Oct, 2016 1 commit
  7. 07 Oct, 2016 1 commit
    • Add markdown cache columns to the database, but don't use them yet · e94cd6fd
      Nick Thomas authored
      This commit adds a number of _html columns and, with the exception of Note,
      starts updating them whenever the content of their partner fields changes.
      
      Note has a collision with the note_html attr_accessor; that will be fixed later
      
      A background worker for clearing these cache columns is also introduced - use
      `rake cache:clear` to set it off. You can clear the database or Redis caches
      separately by running `rake cache:clear:db` or `rake cache:clear:redis`,
      respectively.
  8. 04 Oct, 2016 2 commits
    • Simplify Mentionable concern instance methods · 4ff345c4
      Paco Guzman authored
      We remove some arguments that are rarely used or 
      used just to simplify setups on specs.
      
      Modified Mentionable#create_new_cross_references method 
      we don’t need to calculate previous references to avoid the 
      duplication because we do that at database level when 
      creating references extracted from the current entity state.
      
      MergeRequests won’t create cross_references for commits that are included so we change a spec to use a different merge request to make references to commits to other branches
  9. 03 Oct, 2016 4 commits
  10. 01 Oct, 2016 2 commits
  11. 30 Sep, 2016 1 commit
  12. 29 Sep, 2016 1 commit
  13. 22 Sep, 2016 2 commits
  14. 20 Sep, 2016 3 commits
    • Implement (some) comments from @DouweM's review. · 71d4bf72
      Timothy Andrew authored
      - Move things common to `Issue` and `MergeRequest` into `Issuable`
      - Move more database-specific functions into `Gitlab::Database`
      - Indentation changes and other minor refactorings.
    • Implement review comments from @yorickpeterse · 8957293d
      Timothy Andrew authored
      1. Change multiple updates to a single `update_all`
      
      2. Use cascading deletes
      
      3. Extract an average function for the database median.
      
      4. Move database median to `lib/gitlab/database`
      
      5. Use `delete_all` instead of `destroy_all`
      
      6. Minor refactoring
    • Implement a database median strategy for MySQL. · 4ff8d5d2
      Timothy Andrew authored
      1. Dispatch between the two strategies automatically based on the
         current database type.
      
      2. The MySQL version needs to run multiple statements, so the
         `cycle_analytics` model is modified to support this.
  15. 19 Sep, 2016 2 commits
  16. 18 Sep, 2016 1 commit
  17. 17 Sep, 2016 1 commit
    • Move cycle analytics calculations to SQL. · 7d69ff3d
      Timothy Andrew authored
      1. Use Arel for composable queries.
      2. For a project with ~10k issues, the page loads in around 600ms.
         Previously, a project with ~5k issues would have a ~20s page load
         time.
  18. 14 Sep, 2016 1 commit
  19. 13 Sep, 2016 1 commit
  20. 12 Sep, 2016 1 commit
  21. 01 Sep, 2016 1 commit
  22. 31 Aug, 2016 1 commit