- 29 Nov, 2016 1 commit
-
-
Douwe Maan authored
Fix information disclosure in `Projects::BlobController#update` It was possible to discover private project names by modifying `from_merge_request`parameter in `Projects::BlobController#update`. This fixes that. - [ ] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG.md) entry added - Tests - [x] Added for this feature/bug - [ ] All builds are passing - [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html) - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) https://gitlab.com/gitlab-org/gitlab-ce/issues/22869 See merge request !2023
-
- 28 Nov, 2016 2 commits
-
-
Sean McGivern authored
-
Sean McGivern authored
In the browser, we remove the + and - signs from the front of a diff line because we add them in with CSS, so they aren't copied. We can't do that in an email, because the CSS isn't supported, so we should keep them in that case.
-
- 15 Nov, 2016 1 commit
-
-
Yar authored
Right now, the following naming scheme for diff files is used: diff-1, diff-2, ... and also we have "internal" format which is file-path-HASH, where HASH is sha1 of file path. Besides, we have HASH_lineA_lineB format to link exact line number in MR diff. It makes sence to unify the way we link diff from outside, while leave "file-path-HASH" format for internal (js) usage. Changes in this commit allow to link diff just by HASH, if we don't want specify exact lines, also it changes "file-path-HASH" and "diff-NUMBER" links in code to this unified format. Inspired by #24010 and !7298
-
- 14 Nov, 2016 1 commit
-
-
Stan Hu authored
Steps to reproduce: 1. Start with a repo with an image 2. Add a commit to delete the image 3. Add another commit to replace the image with another image In a diff comparison, we really just compare about what the image was before the diff, not the direct parent of the last commit. This MR fixes that. Closes #3893, gitlab-org/gitlab-ee#678 Signed-off-by: Rémy Coutable <remy@rymai.me>
-
- 10 Nov, 2016 1 commit
-
-
Adam Niedzielski authored
In this case comparing old_path and new_path is not enough because there are two entires that match.
-
- 04 Nov, 2016 2 commits
-
-
Jacob Schatz authored
Add CHANGELOG uses fa-fw from font awesome instead of using declaring fix width explicitly moves changelog entry under 8.14 rebased with master
-
Hiroyuki Sato authored
-
- 31 Oct, 2016 1 commit
-
-
Phil Hughes authored
Closes #23591
-
- 25 Oct, 2016 1 commit
-
-
Luke Bennett authored
-
- 10 Oct, 2016 1 commit
-
-
Phil Hughes authored
Closes #23108
-
- 06 Oct, 2016 1 commit
-
-
Paco Guzman authored
-
- 29 Sep, 2016 1 commit
-
-
Mike Greiling authored
-
- 20 Sep, 2016 2 commits
-
-
Mike Greiling authored
see #22343 for issue description
-
Bryce Johnson authored
-
- 14 Sep, 2016 1 commit
-
-
Bryce Johnson authored
-
- 03 Sep, 2016 1 commit
-
-
Luke Bennett authored
-
- 19 Aug, 2016 2 commits
-
-
Douwe Maan authored
-
Douwe Maan authored
-
- 18 Aug, 2016 1 commit
-
-
Paco Guzman authored
-
- 17 Aug, 2016 1 commit
-
-
Sean McGivern authored
Outlook seems to handle `white-space: pre` weirdly, so just use `pre` elements (but only for emails!).
-
- 10 Aug, 2016 1 commit
-
-
Paco Guzman authored
-
- 04 Aug, 2016 2 commits
-
-
Tim Masliuchenko authored
-
Herminio Torres authored
Magic Variable - Change the name of the variable to assign the local variable for partial, rather than `i` use the `index`. Don't pass a local variable called `i` to a partial.
-
- 03 Aug, 2016 4 commits
-
-
Paco Guzman authored
So we have raw_diffs too
-
Paco Guzman authored
This object will manage Gitlab::Git::Compare instances
-
Paco Guzman authored
Instead calling diff_collection.count use diff_collection.size which is cache on the diff_collection
-
Paco Guzman authored
Introducing the concept of SafeDiffs which relates diffs with UI highlighting.
-
- 01 Aug, 2016 1 commit
-
-
Paco Guzman authored
-
- 30 Jul, 2016 1 commit
-
-
Stan Hu authored
On a merge request with over 1000 changed files, there were redundant calls to blob_text_viewable?, which incurred about 7% of the time. Improves #14775
-
- 29 Jul, 2016 1 commit
-
-
Paco Guzman authored
-
- 26 Jul, 2016 1 commit
-
-
Sean McGivern authored
We can't reuse the existing value of the format parameter, because on the merge request page that's 'json', so the link would go to a JSON file. We can't set it to HTML, because that adds '.html' the URL, which breaks the compare view (and looks bad). Setting it to nil uses the default format, which in all of these cases is HTML anyway.
-
- 20 Jul, 2016 1 commit
-
-
Douwe Maan authored
-
- 18 Jul, 2016 1 commit
-
-
Paco Guzman authored
-
- 11 Jul, 2016 1 commit
-
-
Sean McGivern authored
-
- 08 Jul, 2016 5 commits
-
-
Sean McGivern authored
-
Sean McGivern authored
-
Sean McGivern authored
Other diffs (those that are too large to render anyway, image diffs, diffs suppressed by .gitattributes) should be rendered immediately.
-
Sean McGivern authored
With the option to expand and collapse individual diffs, these aren't needed any more.
-
Sean McGivern authored
When rendering a list of diff files, skip those where the diff is over 10 KB and provide an endpoint to render individually instead.
-