- 28 Aug, 2017 1 commit
-
-
Oswaldo Ferreira authored
-
- 25 Aug, 2017 1 commit
-
-
Nick Thomas authored
If the project is in a group, the `group.refresh_members_authorized_projects` is made non-blocking, and we call `current_user.refresh_authorized_projects` directly. Projects in a personal namespace are more difficult. Rather than passing the `blocking:` parameter through the entire `add_master` chain, have the `AuthorizedProjectsWorker` automatically inline authorizations for three IDs or less. Since the maximum number of IDs in this path is 2, that has the same effect.
-
- 23 Aug, 2017 1 commit
-
-
Grzegorz Bizon authored
-
- 22 Aug, 2017 6 commits
-
-
Toon Claes authored
There might be some projects where the namespace was removed, but the project wasn't. For these the projects still have a `namespace_id` set. So this adds a post-deploy migration remove all projects that are pending delete, and have a `namespace_id` that is non-existing.
-
Grzegorz Bizon authored
Since this already exists in `every_sidekiq_worker_spec.rb`.
-
Grzegorz Bizon authored
-
Grzegorz Bizon authored
-
Nick Thomas authored
-
Gabriel Mazetto authored
-
- 21 Aug, 2017 6 commits
-
-
Grzegorz Bizon authored
-
Grzegorz Bizon authored
-
Grzegorz Bizon authored
-
Grzegorz Bizon authored
-
Grzegorz Bizon authored
-
Grzegorz Bizon authored
-
- 17 Aug, 2017 1 commit
-
-
Tiago Botelho authored
Backports EE mirror stuck handling feature (https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/2628) to CE
-
- 16 Aug, 2017 1 commit
-
-
Douwe Maan authored
-
- 10 Aug, 2017 1 commit
-
-
Yorick Peterse authored
This commit migrates events data in such a way that push events are stored much more efficiently. This is done by creating a shadow table called "events_for_migration", and a table called "push_event_payloads" which is used for storing push data of push events. The background migration in this commit will copy events from the "events" table into the "events_for_migration" table, push events in will also have a row created in "push_event_payloads". This approach allows us to reclaim space in the next release by simply swapping the "events" and "events_for_migration" tables, then dropping the old events (now "events_for_migration") table. The new table structure is also optimised for storage space, and does not include the unused "title" column nor the "data" column (since this data is moved to "push_event_payloads"). == Newly Created Events Newly created events are inserted into both "events" and "events_for_migration", both using the exact same primary key value. The table "push_event_payloads" in turn has a foreign key to the _shadow_ table. This removes the need for recreating and validating the foreign key after swapping the tables. Since the shadow table also has a foreign key to "projects.id" we also don't have to worry about orphaned rows. This approach however does require some additional storage as we're duplicating a portion of the events data for at least 1 release. The exact amount is hard to estimate, but for GitLab.com this is expected to be between 10 and 20 GB at most. The background migration in this commit deliberately does _not_ update the "events" table as doing so would put a lot of pressure on PostgreSQL's auto vacuuming system. == Supporting Both Old And New Events Application code has also been adjusted to support push events using both the old and new data formats. This is done by creating a PushEvent class which extends the regular Event class. Using Rails' Single Table Inheritance system we can ensure the right class is used for the right data, which in this case is based on the value of `events.action`. To support displaying old and new data at the same time the PushEvent class re-defines a few methods of the Event class, falling back to their original implementations for push events in the old format. Once all existing events have been migrated the various push event related methods can be removed from the Event model, and the calls to `super` can be removed from the methods in the PushEvent model. The UI and event atom feed have also been slightly changed to better handle this new setup, fortunately only a few changes were necessary to make this work. == API Changes The API only displays push data of events in the new format. Supporting both formats in the API is a bit more difficult compared to the UI. Since the old push data was not really well documented (apart from one example that used an incorrect "action" nmae) I decided that supporting both was not worth the effort, especially since events will be migrated in a few days _and_ new events are created in the correct format.
-
- 09 Aug, 2017 1 commit
-
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
- 07 Aug, 2017 2 commits
-
-
Oswaldo Ferreira authored
-
Jarka Kadlecova authored
-
- 03 Aug, 2017 1 commit
-
-
Lin Jen-Shin authored
`:mailer` is needed to pick it easily, while `type: :mailer` is needed for picking it automatically for tests located in spec/mailers/*_spec.rb It's a bit complicated in spec/services/notification_service_spec.rb but we'll leave it alone for now.
-
- 02 Aug, 2017 2 commits
-
-
Robert Speicher authored
-
Lin Jen-Shin authored
Also make it easier to have mailer helper
-
- 01 Aug, 2017 2 commits
-
-
Robert Speicher authored
-
Gabriel Mazetto authored
-
- 31 Jul, 2017 1 commit
-
-
Grzegorz Bizon authored
-
- 28 Jul, 2017 1 commit
-
-
Kim "BKC" Carlbäcker authored
-
- 27 Jul, 2017 3 commits
-
-
Alexis Reigel authored
-
Alexis Reigel authored
-
Alexis Reigel authored
-
- 26 Jul, 2017 1 commit
-
-
Tiago Botelho authored
-
- 20 Jul, 2017 1 commit
-
-
Tiago Botelho authored
-
- 11 Jul, 2017 1 commit
-
-
Paul Charlton authored
-
- 07 Jul, 2017 1 commit
-
-
Grzegorz Bizon authored
-
- 06 Jul, 2017 1 commit
-
-
Yorick Peterse authored
This removes the need for relying on Rails' "dependent" option for data removal, which is _incredibly_ slow (even when using :delete_all) when deleting large amounts of data. This also ensures data consistency is enforced on DB level and not on application level (something Rails is really bad at). This commit also includes various migrations to add foreign keys to tables that eventually point to "projects" to ensure no rows get orphaned upon removing a project.
-
- 29 Jun, 2017 1 commit
-
-
Grzegorz Bizon authored
-
- 27 Jun, 2017 1 commit
-
-
Alejandro Rodríguez authored
-
- 21 Jun, 2017 1 commit
-
-
Grzegorz Bizon authored
-
- 16 Jun, 2017 1 commit
-
-
Michael Kozono authored
-