BigW Consortium Gitlab
Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
G
gitlab-ce
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
Forest Godfrey
gitlab-ce
Commits
48776f27
Commit
48776f27
authored
Aug 21, 2017
by
Grzegorz Bizon
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Simplify pipeline sidekiq queues naming scheme
parent
ce274fd6
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
10 additions
and
10 deletions
+10
-10
pipeline_queue.rb
app/workers/concerns/pipeline_queue.rb
+4
-4
pipeline_update_worker.rb
app/workers/pipeline_update_worker.rb
+1
-1
sidekiq_queues.yml
config/sidekiq_queues.yml
+1
-1
pipeline_queue_spec.rb
spec/workers/concerns/pipeline_queue_spec.rb
+4
-4
No files found.
app/workers/concerns/pipeline_queue.rb
View file @
48776f27
...
...
@@ -5,14 +5,14 @@ module PipelineQueue
extend
ActiveSupport
::
Concern
included
do
sidekiq_options
queue:
'pipeline
s-
default'
sidekiq_options
queue:
'pipeline
_
default'
end
class_methods
do
def
enqueue_in
(
queue
:,
group
:)
raise
ArgumentError
if
queue
.
empty?
||
group
.
empty?
def
enqueue_in
(
group
:)
raise
ArgumentError
,
'Unspecified queue group!'
if
group
.
empty?
sidekiq_options
queue:
"pipeline
s-
#{
queue
}
-
#{
group
}
"
sidekiq_options
queue:
"pipeline
_
#{
group
}
"
end
end
end
app/workers/pipeline_update_worker.rb
View file @
48776f27
...
...
@@ -2,7 +2,7 @@ class PipelineUpdateWorker
include
Sidekiq
::
Worker
include
PipelineQueue
enqueue_in
queue: :pipeline
,
group: :processing
enqueue_in
group: :processing
def
perform
(
pipeline_id
)
Ci
::
Pipeline
.
find_by
(
id:
pipeline_id
)
...
...
config/sidekiq_queues.yml
View file @
48776f27
...
...
@@ -27,7 +27,7 @@
-
[
new_merge_request
,
2
]
-
[
build
,
2
]
-
[
pipeline
,
2
]
-
[
pipeline
s-pipeline-
processing
,
2
]
-
[
pipeline
_
processing
,
2
]
-
[
gitlab_shell
,
2
]
-
[
email_receiver
,
2
]
-
[
emails_on_push
,
2
]
...
...
spec/workers/concerns/pipeline_queue_spec.rb
View file @
48776f27
...
...
@@ -10,15 +10,15 @@ describe PipelineQueue do
it
'sets a default pipelines queue automatically'
do
expect
(
worker
.
sidekiq_options
[
'queue'
])
.
to
eq
'pipeline
s-
default'
.
to
eq
'pipeline
_
default'
end
describe
'.enqueue_in'
do
it
'sets a custom sidekiq queue with prefix
, name
and group'
do
worker
.
enqueue_in
(
queue: :build
,
group: :processing
)
it
'sets a custom sidekiq queue with prefix and group'
do
worker
.
enqueue_in
(
group: :processing
)
expect
(
worker
.
sidekiq_options
[
'queue'
])
.
to
eq
'pipeline
s-build-
processing'
.
to
eq
'pipeline
_
processing'
end
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment