BigW Consortium Gitlab

  1. 13 Jun, 2016 1 commit
  2. 10 Jun, 2016 1 commit
  3. 09 Jun, 2016 1 commit
    • Implement the correct linking behaviour in `WikiLinkFilter`. · 8e71c19a
      Timothy Andrew authored
      Original Comments
      =================
      
      - Linking behaves as per rules documented here:
        https://gitlab.com/gitlab-org/gitlab-ce/blob/16568-document-wiki-linking-behavior/doc/markdown/wiki.md
      - All links (to other wiki pages) are rewritten to be at the level of
        the app root. We can't use links relative to the current
        page ('./foo', 'foo', '../foo'), because they won't work in the
        markdown preview, where the current page is suffixed with `/edit`
      - Move existing `WikiLinkFilter` specs to `WikiPipeline` spec. It makes
        sense to run these tests on the combined output of the pipeline,
        rather than a single filter, since we can catch issues with
        conflicting filters.
      - Add more tests to cover the new linking
      
      @rymai's Review
      ===============
      
      - Classes nested under `WikiLinkFilter` should declare `WikiLinkFilter`'s
        inherit, so nothing changes if the nested class is loaded first.
      - Add a blank line after a guard clause
      - Use keyword arguments for the `Rewriter` constructor
      - Invert a condition - use `if` instead of `unless`
      - Inline a `let` in `WikiPipeline` spec - it was only used in a single place
      - Change out of date spec names
      - Add a comment for every rewrite rule in `Rewriter`
  4. 02 Jun, 2016 3 commits
    • Reduce Namespace queries in UserReferenceFilter · 01575e99
      Yorick Peterse authored
      This changes UserReferenceFilter so it operates using the following
      steps:
      
      1. Grab all username references from the input document.
      2. Query the corresponding Namespace objects using a single query.
      3. Iterate over all nodes to build links while re-using the objects
         queried in step 2.
      
      The impact of these changes is that a comment mentioning 5 different
      usernames no longer runs 5 different queries (1 for every username),
      instead it only runs a single query.
    • Added ReferenceFilter#nodes · 8a6c3f27
      Yorick Peterse authored
      This method returns an Array of the HTML nodes as yielded by
      ReferenceFilter#each_node. The method's return value is memoized to
      allow multiple calls without having to re-query the input document.
    • Returning enums in ReferenceFilter#each_node · 2fbfb854
      Yorick Peterse authored
      This changes ReferenceFilter#each_node so that when it's called without
      a block an Enumerator is returned.
  5. 26 May, 2016 1 commit
    • Split Markdown rendering & reference gathering · 86166d28
      Yorick Peterse authored
      This splits the Markdown rendering and reference extraction phases into
      two distinct code bases. The reference extraction phase no longer relies
      on the html-pipeline Gem (and any related code) and allows for
      extracting of references from multiple HTML nodes in a single pass. This
      means that if you want to extract user references from 200 comments you
      no longer need to run 200 times N number of queries, instead only a
      handful of queries may be needed.
  6. 18 May, 2016 1 commit
  7. 12 May, 2016 2 commits
  8. 10 May, 2016 2 commits
  9. 09 May, 2016 1 commit
  10. 05 May, 2016 1 commit
  11. 21 Apr, 2016 5 commits
  12. 06 Apr, 2016 3 commits
  13. 05 Apr, 2016 1 commit
  14. 30 Mar, 2016 1 commit
  15. 20 Mar, 2016 2 commits
  16. 18 Mar, 2016 1 commit
  17. 17 Mar, 2016 4 commits
  18. 14 Mar, 2016 1 commit
  19. 04 Mar, 2016 1 commit
  20. 03 Mar, 2016 5 commits
  21. 01 Mar, 2016 2 commits