- 06 Jul, 2017 40 commits
-
-
Filipa Lacerda authored
-
Phil Hughes authored
Revert "Merge branch 'winh-mr-widget-no-pipeline' into 'master'" See merge request !12674
-
Douwe Maan authored
Backports for ee-2112 Closes #34716 See merge request !12671
-
Douwe Maan authored
Add Traditional Chinese in Taiwan translations of Commits Page See merge request !12407
-
Kamil Trzciński authored
Generate KUBECONFIG in KubernetesService#predefined_variables Closes #33360 See merge request !12223
-
Douwe Maan authored
Fix `migration:path` build for "Honor the 'Remember me' parameter for OAuth-based login" Closes #34713 See merge request !12668
-
Sean McGivern authored
Add foreign keys to various tables that point to the "projects" table See merge request !9388
-
Lin Jen-Shin authored
-
Tim Zallmann authored
Update Prometheus Metrics Library See merge request !12621
-
Rémy Coutable authored
Fix stubbing attributes alongside cache_markdown_field Closes #34698 See merge request !12661
-
Kamil Trzciński authored
This reverts merge request !12127
-
Yorick Peterse authored
This cop has been renamed to ActiveRecordSerialize to match the way "ActiveRecord" is usually written.
-
Yorick Peterse authored
These IDs point to non-existing rows, causing the foreign key constraints to fail.
-
Yorick Peterse authored
This is allowed for existing instances so we don't end up 76 offenses right away, but for new code one should _only_ use this if they _have_ to remove non database data. Even then it's usually better to do this in a service class as this gives you more control over how to remove the data (e.g. in bulk).
-
Yorick Peterse authored
This removes the need for relying on Rails' "dependent" option for data removal, which is _incredibly_ slow (even when using :delete_all) when deleting large amounts of data. This also ensures data consistency is enforced on DB level and not on application level (something Rails is really bad at). This commit also includes various migrations to add foreign keys to tables that eventually point to "projects" to ensure no rows get orphaned upon removing a project.
-
Rémy Coutable authored
Add user projects API Closes #33657 See merge request !12596
-
Grzegorz Bizon authored
Fix a nasty transient failure happening is a subsequent spec Closes #34698 See merge request !12664
-
Huang Tao authored
-
Sean McGivern authored
Fix invalid integer value when more than 1000 commits Closes #34711 See merge request !12659
-
Lin Jen-Shin authored
-
Lin Jen-Shin authored
* upstream/master: (888 commits) Fix Rubocop offense Use a previous approach for cycle analytics dummy pipeline Allow admin to disable all restricted visibility levels Removes file_name_regex from Gitlab::Regex Remove IIFEs around several javascript classes Update CHANGELOG.md for 9.3.5 Add ProjectPathHelper cop Create and use project path helpers that only need a project, no namespace Handles realtime with 2 states for environments table Revert "Merge branch '18000-remember-me-for-oauth-login' into 'master'" Allow creation of files and directories with spaces in web UI Disable Flipper memoizer in tests to avoid transient failures Introduce cache policies for CI jobs fix sidebar padding for full-width items (Time Tracking help) Replace 'snippets/snippets.feature' spinach with rspec Rename ci_config_file to ci_config_path Add back Pipeline#ci_yaml_file_path due to all the troubles Revert change to design. Go back to scrollable page Fix cycle analytics tests by making pipeline valid Fixes the column widths for the new navigation options in settings ...
-
Kamil Trzciński authored
Introduce cache policies for CI jobs Closes #33772 See merge request !12483
-
Grzegorz Bizon authored
Resolve "Project option to allow customizing CI/CD config path" Closes #32815 and #33130 See merge request !12509
-
Grzegorz Bizon authored
-
Grzegorz Bizon authored
-
Timothy Andrew authored
- This is causing autoload-related errors in the `migration:path` builds. We need to find a better way of testing this provider.
-
Timothy Andrew authored
-
Timothy Andrew authored
- Don't use `request.env['omniauth.params']` if it isn't present. - Remove the `saml` section from the `gitlab.yml` test section. Some tests depend on this section not being initially present, so it can be overridden in the test. This MR doesn't add any tests for SAML, so we didn't really need this in the first place anyway. - Clean up the test -> omniauth section of `gitlab.yml`
-
Timothy Andrew authored
- Disable an ESLint check rather than work around it (by converting `OAuthRememberMe` from a regular class to a static class. - Scope `$` calls inside `OAuthRememberMe`
-
Timothy Andrew authored
- Change double quotes to single quotes. - Why is `OmniAuth.config.full_host` being reassigned in the integration test? - Use `map` over `map!` to avoid `dup` in the `gitlab:info` rake task - Other minor changes
-
Timothy Andrew authored
- The test for `rake gitlab:env:info` executed the rake task, which mutated the list of omniauth providers, breaking subsequent tests relying on this list. - I've changed the rake task to duplicate the providers list before modifying it.
-
Timothy Andrew authored
-
Timothy Andrew authored
-
Timothy Andrew authored
- I tried to get this to work by stubbing out portions of the config within the test. This didn't work as expected because Devise/Omniauth loaded before the stub could run, and the stubbed config was ignored. - I attempted to fix this by reloading Devise/Omniauth after stubbing the config. This successfully got Devise to load the stubbed providers, but failed while trying to access a route such as `user_gitlab_omniauth_authorize_path`. - I spent a while trying to figure this out (even trying `Rails.application.reload_routes!`), but nothing seemed to work. - I settled for adding this config directly to `gitlab.yml` rather than go down this path any further.
-
Timothy Andrew authored
- Added saml, authentiq, cas3, and auth0 - Crowd seems to be a special case that will be handled separately.
-
Timothy Andrew authored
-
Timothy Andrew authored
-
Timothy Andrew authored
- There was previously a test for `saml` login in `login_spec`, but this didn't seem to be passing. A lot of things didn't seem right here, and I suspect that this test hasn't been running. I'll investigate this further. - It took almost a whole working day to figure out this line: OmniAuth.config.full_host = ->(request) { request['REQUEST_URI'].sub(request['REQUEST_PATH'], '') } As always, it's obvious in retrospect, but it took some digging to figure out tests were failing and returning 404s during the callback phase. - Test all OAuth providers - github, twitter, bitbucket, gitlab, google, and facebook
-
Timothy Andrew authored
- Pass a `remember_me` query parameter along with the initial OAuth request, and pick this parameter up during the omniauth callback from request.env['omniauth.params']`. - For 2FA-based login, copy the `remember_me` param from `omniauth.params` to `params`, which the 2FA process will pick up. - For non-2FA-based login, simply call the `remember_me` devise method to set the session cookie.
-