Implement review comments for !11963 from @filipa.

- Disable an ESLint check rather than work around it (by converting `OAuthRememberMe` from a regular class to a static class. - Scope `$` calls inside `OAuthRememberMe`

Implement review comments for !11963 from @filipa.
f1caa0b3 · Timothy Andrew · 8fa08ea3 · f1caa0b3 · f1caa0b3
Commit f1caa0b3 authored Jul 03, 2017 by Timothy Andrew
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 4 deletions

dispatcher.js app/assets/javascripts/dispatcher.js +1 -1

oauth_remember_me.js app/assets/javascripts/oauth_remember_me.js +4 -3

No files found.
--- a/app/assets/javascripts/dispatcher.js
+++ b/app/assets/javascripts/dispatcher.js
@@ -128,7 +128,7 @@ import OAuthRememberMe from './oauth_remember_me';
        case 'sessions:new':
          new UsernameValidator();
          new ActiveTabMemoizer();
-          new OAuthRememberMe({ container: $("#remember_me") }).bindEvents();
+          new OAuthRememberMe({ container: $(".omniauth-container") }).bindEvents();
          break;
        case 'projects:boards:show':
        case 'projects:boards:index':

--- a/app/assets/javascripts/oauth_remember_me.js
+++ b/app/assets/javascripts/oauth_remember_me.js
@@ -12,13 +12,14 @@ export default class OAuthRememberMe {
  }

  bindEvents() {
-    this.container.on('click', this.constructor.toggleRememberMe);
+    $('#remember_me', this.container).on('click', this.toggleRememberMe);
  }

-  static toggleRememberMe(event) {
+  // eslint-disable-next-line class-methods-use-this
+  toggleRememberMe(event) {
    const rememberMe = $(event.target).is(':checked');

-    $('.oauth-login').each((i, element) => {
+    $('.oauth-login', this.container).each((i, element) => {
      const href = $(element).attr('href');

      if (rememberMe) {