Clean up Banzai HTML for HipChat

The `class` and `data-*` attributes are meaningless in HipChat, and it would probably be better to limit the tags, too. For example, we could avoid block-level elements in `render_line`.

Clean up Banzai HTML for HipChat
551c74ed · David Eisner · blackst0ne · 73f13526 · 551c74ed
Commit 551c74ed authored Oct 04, 2016 by David Eisner Committed by blackst0ne Oct 21, 2016
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 0 deletions

hipchat_service.rb app/models/project_services/hipchat_service.rb +3 -0

No files found.
--- a/app/models/project_services/hipchat_service.rb
+++ b/app/models/project_services/hipchat_service.rb
 class HipchatService < Service
+  include ActionView::Helpers::SanitizeHelper
+
  MAX_COMMITS = 3

  prop_accessor :token, :room, :server, :notify, :color, :api_version
@@ -138,6 +140,7 @@ class HipchatService < Service

      html = Banzai.render(text, context)
      html = Banzai.post_process(html, context)
+      sanitize html, attributes: %w(href title alt)
    else
      ""
    end