Ensure absolute URLs for single lines from Banzai for HipChat

"pipeline: :single_line" leaves the protocol/host part out of the URLs and caches them that way. To avoid giving those out to HipChat, markdown is always rendered with "pipeline: :email" first. There must be a better way to do this, but I can't see how to avoid the link caching.

Ensure absolute URLs for single lines from Banzai for HipChat
73f13526 · David Eisner · blackst0ne · 59b2770a · 73f13526
Commit 73f13526 authored Oct 04, 2016 by David Eisner Committed by blackst0ne Oct 21, 2016
Hide whitespace changes
Inline Side-by-side

Showing with 7 additions and 3 deletions

hipchat_service.rb app/models/project_services/hipchat_service.rb +7 -3

No files found.
--- a/app/models/project_services/hipchat_service.rb
+++ b/app/models/project_services/hipchat_service.rb
@@ -125,12 +125,16 @@ class HipchatService < Service
    message
  end

-  def markdown(text, context = {})
+  def markdown(text, options = {})
    if text
-      context = ({
+      context = {
        project: project,
        pipeline: :email
-      }).merge(context)
+      }
+
+      Banzai.render(text, context)
+
+      context.merge!(options)

      html = Banzai.render(text, context)
      html = Banzai.post_process(html, context)