BigW Consortium Gitlab

Skip to content

M
mangoh-drivers
Commit bcfd3e78 by David Frey
Options

Simplify Makefile

The mangOH build is failing in the developer VM based on Ubuntu 18.04 because the wrong toolchain is being selected for the red_wp85 build. I think the root cause may have to do with the .phony target that sets up the Make variables not being run multiple times. Rather than spending a lot of time on this, I have just simplified the Makefile so that the problem goes away.
parent 8aa4f9ff
Showing with 24 additions and 37 deletions
Makefile
...@@ -34,72 +34,59 @@ else ...@@ -34,72 +34,59 @@ else
$(MAKE) -C $(LEGATO_ROOT) framework_$(LEGATO_TARGET) $(MAKE) -C $(LEGATO_ROOT) framework_$(LEGATO_TARGET)
endif endif
.PHONY: module_env_%
module_env_%: legato_%
$(eval MODULE := $(subst module_env_,,$@))
$(eval MODULE_UPPER := $(shell echo $(MODULE) | tr [a-z] [A-Z]))
$(eval $(MODULE_UPPER)_TOOLCHAIN_DIR := $(shell $(LEGATO_ROOT)/bin/findtoolchain $(MODULE) dir))
$(eval $(MODULE_UPPER)_TOOLCHAIN_PREFIX := $(shell $(LEGATO_ROOT)/bin/findtoolchain $(MODULE) prefix))
$(eval TOOLCHAIN_DIR := $($(MODULE_UPPER)_TOOLCHAIN_DIR))
$(eval TOOLCHAIN_PREFIX := $($(MODULE_UPPER)_TOOLCHAIN_PREFIX))
echo "TOOLCHAIN_DIR=$(TOOLCHAIN_DIR), TOOLCHAIN_PREFIX=$(TOOLCHAIN_PREFIX)"
ifeq ($(LEGATO_SYSROOT),)
$(eval LEGATO_SYSROOT := $($(MODULE_UPPER)_SYSROOT))
endif
.PHONY: green_wp85 .PHONY: green_wp85
green_wp85: module_env_wp85 green_wp85: legato_wp85
TOOLCHAIN_DIR=$(TOOLCHAIN_DIR) \ TOOLCHAIN_DIR=$(shell $(LEGATO_ROOT)/bin/findtoolchain wp85 dir) \
TOOLCHAIN_PREFIX=$(TOOLCHAIN_PREFIX) \ TOOLCHAIN_PREFIX=$(shell $(LEGATO_ROOT)/bin/findtoolchain wp85 prefix) \
MANGOH_BOARD=GREEN \ MANGOH_BOARD=GREEN \
mksys -t wp85 $(MKSYS_ARGS_COMMON) $(MKSYS_ARGS_GREEN) mangOH.sdef mksys -t wp85 $(MKSYS_ARGS_COMMON) $(MKSYS_ARGS_GREEN) mangOH.sdef
.PHONY: green_wp750x .PHONY: green_wp750x
green_wp750x: module_env_wp750x green_wp750x: legato_wp750x
TOOLCHAIN_DIR=$(TOOLCHAIN_DIR) \ TOOLCHAIN_DIR=$(shell $(LEGATO_ROOT)/bin/findtoolchain wp750x dir) \
TOOLCHAIN_PREFIX=$(TOOLCHAIN_PREFIX) \ TOOLCHAIN_PREFIX=$(shell $(LEGATO_ROOT)/bin/findtoolchain wp750x prefix) \
MANGOH_BOARD=GREEN \ MANGOH_BOARD=GREEN \
mksys -t wp750x $(MKSYS_ARGS_COMMON) $(MKSYS_ARGS_GREEN) mangOH.sdef mksys -t wp750x $(MKSYS_ARGS_COMMON) $(MKSYS_ARGS_GREEN) mangOH.sdef
.PHONY: green_wp76xx .PHONY: green_wp76xx
green_wp76xx: module_env_wp76xx green_wp76xx: legato_wp76xx
TOOLCHAIN_DIR=$(TOOLCHAIN_DIR) \ TOOLCHAIN_DIR=$(shell $(LEGATO_ROOT)/bin/findtoolchain wp76xx dir) \
TOOLCHAIN_PREFIX=$(TOOLCHAIN_PREFIX) \ TOOLCHAIN_PREFIX=$(shell $(LEGATO_ROOT)/bin/findtoolchain wp76xx prefix) \
MANGOH_BOARD=GREEN \ MANGOH_BOARD=GREEN \
mksys -t wp76xx $(MKSYS_ARGS_COMMON) $(MKSYS_ARGS_GREEN) mangOH.sdef mksys -t wp76xx $(MKSYS_ARGS_COMMON) $(MKSYS_ARGS_GREEN) mangOH.sdef
.PHONY: green_wp77xx .PHONY: green_wp77xx
green_wp77xx: module_env_wp77xx green_wp77xx: legato_wp77xx
TOOLCHAIN_DIR=$(TOOLCHAIN_DIR) \ TOOLCHAIN_DIR=$(shell $(LEGATO_ROOT)/bin/findtoolchain wp77xx dir) \
TOOLCHAIN_PREFIX=$(TOOLCHAIN_PREFIX) \ TOOLCHAIN_PREFIX=$(shell $(LEGATO_ROOT)/bin/findtoolchain wp77xx prefix) \
MANGOH_BOARD=GREEN \ MANGOH_BOARD=GREEN \
mksys -t wp77xx $(MKSYS_ARGS_COMMON) $(MKSYS_ARGS_GREEN) mangOH.sdef mksys -t wp77xx $(MKSYS_ARGS_COMMON) $(MKSYS_ARGS_GREEN) mangOH.sdef
.PHONY: red_wp85 .PHONY: red_wp85
red_wp85: module_env_wp85 red_wp85: legato_wp85
TOOLCHAIN_DIR=$(TOOLCHAIN_DIR) \ TOOLCHAIN_DIR=$(shell $(LEGATO_ROOT)/bin/findtoolchain wp85 dir) \
TOOLCHAIN_PREFIX=$(TOOLCHAIN_PREFIX) \ TOOLCHAIN_PREFIX=$(shell $(LEGATO_ROOT)/bin/findtoolchain wp85 prefix) \
MANGOH_BOARD=RED \ MANGOH_BOARD=RED \
mksys -t wp85 $(MKSYS_ARGS_COMMON) $(MKSYS_ARGS_RED) mangOH.sdef mksys -t wp85 $(MKSYS_ARGS_COMMON) $(MKSYS_ARGS_RED) mangOH.sdef
.PHONY: red_wp750x .PHONY: red_wp750x
red_wp750x: module_env_wp750x red_wp750x: legato_wp750x
TOOLCHAIN_DIR=$(TOOLCHAIN_DIR) \ TOOLCHAIN_DIR=$(shell $(LEGATO_ROOT)/bin/findtoolchain wp750x dir) \
TOOLCHAIN_PREFIX=$(TOOLCHAIN_PREFIX) \ TOOLCHAIN_PREFIX=$(shell $(LEGATO_ROOT)/bin/findtoolchain wp750x prefix) \
MANGOH_BOARD=RED \ MANGOH_BOARD=RED \
mksys -t wp750x $(MKSYS_ARGS_COMMON) $(MKSYS_ARGS_RED) mangOH.sdef mksys -t wp750x $(MKSYS_ARGS_COMMON) $(MKSYS_ARGS_RED) mangOH.sdef
.PHONY: red_wp76xx .PHONY: red_wp76xx
red_wp76xx: module_env_wp76xx red_wp76xx: legato_wp76xx
TOOLCHAIN_DIR=$(TOOLCHAIN_DIR) \ TOOLCHAIN_DIR=$(shell $(LEGATO_ROOT)/bin/findtoolchain wp76xx dir) \
TOOLCHAIN_PREFIX=$(TOOLCHAIN_PREFIX) \ TOOLCHAIN_PREFIX=$(shell $(LEGATO_ROOT)/bin/findtoolchain wp76xx prefix) \
MANGOH_BOARD=RED \ MANGOH_BOARD=RED \
mksys -t wp76xx $(MKSYS_ARGS_COMMON) $(MKSYS_ARGS_RED) mangOH.sdef mksys -t wp76xx $(MKSYS_ARGS_COMMON) $(MKSYS_ARGS_RED) mangOH.sdef
.PHONY: red_wp77xx .PHONY: red_wp77xx
red_wp77xx: module_env_wp77xx red_wp77xx: legato_wp77xx
TOOLCHAIN_DIR=$(TOOLCHAIN_DIR) \ TOOLCHAIN_DIR=$(shell $(LEGATO_ROOT)/bin/findtoolchain wp77xx dir) \
TOOLCHAIN_PREFIX=$(TOOLCHAIN_PREFIX) \ TOOLCHAIN_PREFIX=$(shell $(LEGATO_ROOT)/bin/findtoolchain wp77xx prefix) \
MANGOH_BOARD=RED \ MANGOH_BOARD=RED \
mksys -t wp77xx $(MKSYS_ARGS_COMMON) $(MKSYS_ARGS_RED) mangOH.sdef mksys -t wp77xx $(MKSYS_ARGS_COMMON) $(MKSYS_ARGS_RED) mangOH.sdef
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment