BigW Consortium Gitlab
Resolve "External statuses not shown correctly on pipeline page" ## What does this MR do? Updates `generic_commit_status/_generic_commit_status.html.haml` template to match the changes made to `ci/builds/_build.html.haml` which had not previously been carried over. ## Testing 1. Ensure updated fixtures are installed (from !7792) so that these changes are made apparent. (check out the !7792 branch if not yet merged into master, then `bundle exec rake db:drop` and `bundle exec rake dev:setup`) 2. Visit a build list page or an individual pipeline page which contains an external build status. 3. The results should look like this: ### Before: ![Screen_Shot_2016-11-28_at_9.11.27_PM](/uploads/ed8c5beb857cd17147dbddf8f5ecab1d/Screen_Shot_2016-11-28_at_9.11.27_PM.png) ### After: ![Screen_Shot_2016-11-28_at_9.12.05_PM](/uploads/9f953a5f14764e336afa4481a917947f/Screen_Shot_2016-11-28_at_9.12.05_PM.png) ## Are there points in the code the reviewer needs to double check? Look for any places where these partials may be rendered to ensure external status match regular build statuses. ## Why was this MR needed? The generic commit status template has been largely overlooked when changes are made to build table rows which should be duplicated in both places. ## Does this MR meet the acceptance criteria? - [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added - [x] ~~[Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)~~ - [x] ~~API support added~~ - Tests - [x] ~~Added for this feature/bug~~ - [ ] All builds are passing - [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html) - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if it does - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) ## What are the relevant issue numbers? Closes #24710 See merge request !7811
Name |
Last commit
|
Last update |
---|---|---|
.. | ||
abuse_report_mailer | Loading commit data... | |
abuse_reports | Loading commit data... | |
admin | Loading commit data... | |
award_emoji | Loading commit data... | |
ci/lints | Loading commit data... | |
dashboard | Loading commit data... | |
devise | Loading commit data... | |
discussions | Loading commit data... | |
doorkeeper | Loading commit data... | |
email_rejection_mailer | Loading commit data... | |
emojis | Loading commit data... | |
errors | Loading commit data... | |
events | Loading commit data... | |
explore | Loading commit data... | |
groups | Loading commit data... | |
help | Loading commit data... | |
import | Loading commit data... | |
invites | Loading commit data... | |
issues | Loading commit data... | |
kaminari/gitlab | Loading commit data... | |
koding | Loading commit data... | |
layouts | Loading commit data... | |
notify | Loading commit data... | |
profiles | Loading commit data... | |
projects | Loading commit data... | |
repository_check_mailer | Loading commit data... | |
search | Loading commit data... | |
sent_notifications | Loading commit data... | |
shared | Loading commit data... | |
sherlock | Loading commit data... | |
snippets | Loading commit data... | |
u2f | Loading commit data... | |
users | Loading commit data... |