BigW Consortium Gitlab
Fix wiki linking behavior for markdown wiki pages Related to #18019 - As per the documentation in !4372 ## TODO - [ ] !4432 Have wiki linking behave as per the documentation - [x] Move `WikiLinkFilter` specs to the pipeline level - [x] Verify current behavior on wiki `show` page - [x] Fix current behavior on wiki `show` page - [x] Verify current behaviour on wiki preview - [x] Fix current behaviour on wiki preview - [x] Rewrite all links and get preview links working - [x] Make sure all links are on-par with the wiki `show` page - [x] TDD `WikiLinkFilter` and get it working - [x] Hook `WikiLinkFilter` up - [x] Fix tests - [x] Fix `markdown_spec` - [x] Fix `wiki` spinach feature - [x] Wait for [build](https://gitlab.com/gitlab-org/gitlab-ce/commit/4f50dd2/builds) to pass - [x] Make sure all wiki-related pages are working as expected (history, all pages, etc.) - [x] Test in different ruby versions - [x] GitLab instances hosted on a relative URL - [x] Non-markdown rendering formats? - [x] RDoc - [x] ASCIIDoc - [x] Create issues to fix things for RDoc and ASCIIDoc - [x] Gauge performance impact - [x] Refactor - [x] Re-organize commits - [x] Make sure [build](https://gitlab.com/gitlab-org/gitlab-ce/commit/f860e9a8dcabe7d5f160c32fc549807c98baa4a1/builds) passes - [x] Respond to @rymai's comments - [x] `class WikiLinkFilter < HTML::Pipeline::Filter` - [x] blank line after guard clause - [x] keyword arguments for `wiki` and `slug` - [x] invert the condition - [x] inline `user` in spec - [x] Make sure spec names are not out of date - [x] Comment for each rewrite rule - [x] Add CHANGELOG entry - [x] Reorganize commits - [x] Make sure [build](https://gitlab.com/gitlab-org/gitlab-ce/commit/19b91e749a6320d12fb299d33f1f6440777e0e26/builds) passes - [ ] Wait for merge See merge request !4432
Name |
Last commit
|
Last update |
---|---|---|
.. | ||
application_helper_spec.rb | Loading commit data... | |
auth_helper_spec.rb | Loading commit data... | |
blob_helper_spec.rb | Loading commit data... | |
broadcast_messages_helper_spec.rb | Loading commit data... | |
ci_status_helper_spec.rb | Loading commit data... | |
commits_helper_spec.rb | Loading commit data... | |
diff_helper_spec.rb | Loading commit data... | |
emails_helper_spec.rb | Loading commit data... | |
events_helper_spec.rb | Loading commit data... | |
form_helper_spec.rb | Loading commit data... | |
gitlab_markdown_helper_spec.rb | Loading commit data... | |
graph_helper_spec.rb | Loading commit data... | |
groups_helper_spec.rb | Loading commit data... | |
icons_helper_spec.rb | Loading commit data... | |
import_helper_spec.rb | Loading commit data... | |
issues_helper_spec.rb | Loading commit data... | |
labels_helper_spec.rb | Loading commit data... | |
merge_requests_helper_spec.rb | Loading commit data... | |
nav_helper_spec.rb | Loading commit data... | |
notifications_helper_spec.rb | Loading commit data... | |
page_layout_helper_spec.rb | Loading commit data... | |
preferences_helper_spec.rb | Loading commit data... | |
projects_helper_spec.rb | Loading commit data... | |
runners_helper_spec.rb | Loading commit data... | |
search_helper_spec.rb | Loading commit data... | |
submodule_helper_spec.rb | Loading commit data... | |
tab_helper_spec.rb | Loading commit data... | |
time_helper_spec.rb | Loading commit data... | |
tree_helper_spec.rb | Loading commit data... | |
visibility_level_helper_spec.rb | Loading commit data... |