BigW Consortium Gitlab
Improve invalidation of stored service password if the endpoint URL is changed A number of issues were found in !1490 and !1558 (triggered by support request 7395) * It is not possible to set a new URL and a password at the same time (new password is ignored) * An error occurs on the Service Templates admin pages (prop_updated? was referencing the service's project, which is not defined for templates) * Passwords are reset on every save in Service Templates admin pages This should fix these 3 issues by respectively: * Differentiating a property that has been assigned a new value (regardless of the new value) and a property that has been assigned a new value that is different from the old one * Providing an alternate implementation to detected updated properties, not relying on the service's project * Filtering an empty password parameter passed to the Service Templates admin page like on the project service page See merge request !1583
Name |
Last commit
|
Last update |
---|---|---|
.. | ||
benchmarks | Loading commit data... | |
controllers | Loading commit data... | |
factories | Loading commit data... | |
features | Loading commit data... | |
finders | Loading commit data... | |
fixtures | Loading commit data... | |
helpers | Loading commit data... | |
javascripts | Loading commit data... | |
lib | Loading commit data... | |
mailers | Loading commit data... | |
models | Loading commit data... | |
requests | Loading commit data... | |
routing | Loading commit data... | |
services | Loading commit data... | |
support | Loading commit data... | |
tasks/gitlab | Loading commit data... | |
views/help | Loading commit data... | |
workers | Loading commit data... | |
factories.rb | Loading commit data... | |
factories_spec.rb | Loading commit data... | |
rails_helper.rb | Loading commit data... | |
spec_helper.rb | Loading commit data... | |
teaspoon_env.rb | Loading commit data... |