BigW Consortium Gitlab
Replace jquery-cookie plugin with js-cookie ## What does this MR do? Removes an outdated and unmaintained dependency [jquery.cookie](https://github.com/carhartl/jquery-cookie) with its successor [js.cookie](https://github.com/js-cookie/js-cookie) which is not dependent on jQuery. Also this MR adds a global default cookie `path` setting which defaults to the GitLab root directory. Now, setting a cookie to any path other than `gon.relative_url_root` requires an explicit opt-out. This is a sensible default and should prevent accidental omission going forward. ## Are there points in the code the reviewer needs to double check? Double check that all instances of `$.cookie(x)` have been replaced by `Cookies.get(x)` and all instances of `$.cookie(x, y, z)` are replaced with `Cookies.set(x, y, z)`. All javascripts which set or retrieve cookie values should function just as before. ## Why was this MR needed? One more step toward shaking off jQuery as a dependency (#23022), also [jquery.cookie](https://github.com/carhartl/jquery-cookie) is no longer maintained and hasn't seen an update in 2+ years. ## Does this MR meet the acceptance criteria? - [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG.md) entry added - Tests - [x] All builds are passing - [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html) - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if it does - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) ## What are the relevant issue numbers? #23022 See merge request !7085
Name |
Last commit
|
Last update |
---|---|---|
.. | ||
behaviors | Loading commit data... | |
boards | Loading commit data... | |
extensions | Loading commit data... | |
fixtures | Loading commit data... | |
graphs | Loading commit data... | |
u2f | Loading commit data... | |
abuse_reports_spec.js.es6 | Loading commit data... | |
activities_spec.js.es6 | Loading commit data... | |
application_spec.js | Loading commit data... | |
awards_handler_spec.js | Loading commit data... | |
datetime_utility_spec.js.es6 | Loading commit data... | |
diff_comments_store_spec.js.es6 | Loading commit data... | |
gl_dropdown_spec.js.es6 | Loading commit data... | |
gl_field_errors_spec.js.es6 | Loading commit data... | |
issue_spec.js | Loading commit data... | |
labels_issue_sidebar_spec.js.es6 | Loading commit data... | |
line_highlighter_spec.js | Loading commit data... | |
merge_request_spec.js | Loading commit data... | |
merge_request_tabs_spec.js | Loading commit data... | |
merge_request_widget_spec.js | Loading commit data... | |
new_branch_spec.js | Loading commit data... | |
notes_spec.js | Loading commit data... | |
project_title_spec.js | Loading commit data... | |
right_sidebar_spec.js | Loading commit data... | |
search_autocomplete_spec.js | Loading commit data... | |
shortcuts_issuable_spec.js | Loading commit data... | |
spec_helper.js | Loading commit data... | |
syntax_highlight_spec.js | Loading commit data... | |
zen_mode_spec.js | Loading commit data... |