BigW Consortium Gitlab
Adds JavaScript validation for group path editing ## What does this MR do? - Prevents group_edit form submission when special characters are included in the new group name - Enhances gl_field_errors to support this use case and be more re-usable. ## Are there points in the code the reviewer needs to double check? **The implementation of validation is here: https://gitlab.com/gitlab-org/gitlab-ce/commit/73d997046cac376ccdbcaac6f183002bc19b9a1f** The rest of the diff for this MR is augmenting gl_field_errors ## Why was this MR needed? - Currently we allow submission and a 500 error is returned. ## Screenshots (if relevant) ![2016-10-21_14.11.21](/uploads/2bef5764d3f2429dd0f900661153eef7/2016-10-21_14.11.21.gif) ## Does this MR meet the acceptance criteria? - [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG.md) entry added - [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - [x] All builds are passing - [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html) - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if it does - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) ## What are the relevant issue numbers? Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/23564, https://gitlab.com/gitlab-org/gitlab-ce/issues/19756, https://gitlab.com/gitlab-org/gitlab-ce/issues/19736, https://gitlab.com/gitlab-org/gitlab-ce/issues/23922 See merge request !7041
Name |
Last commit
|
Last update |
---|---|---|
.. | ||
animations.scss | Loading commit data... | |
avatar.scss | Loading commit data... | |
blank.scss | Loading commit data... | |
blocks.scss | Loading commit data... | |
buttons.scss | Loading commit data... | |
calendar.scss | Loading commit data... | |
callout.scss | Loading commit data... | |
common.scss | Loading commit data... | |
dropdowns.scss | Loading commit data... | |
files.scss | Loading commit data... | |
filters.scss | Loading commit data... | |
flash.scss | Loading commit data... | |
fonts.scss | Loading commit data... | |
forms.scss | Loading commit data... | |
gfm.scss | Loading commit data... | |
gitlab-theme.scss | Loading commit data... | |
header.scss | Loading commit data... | |
highlight.scss | Loading commit data... | |
issue_box.scss | Loading commit data... | |
jquery.scss | Loading commit data... | |
layout.scss | Loading commit data... | |
lists.scss | Loading commit data... | |
logo.scss | Loading commit data... | |
markdown_area.scss | Loading commit data... | |
mixins.scss | Loading commit data... | |
mobile.scss | Loading commit data... | |
modal.scss | Loading commit data... | |
nav.scss | Loading commit data... | |
pagination.scss | Loading commit data... | |
panels.scss | Loading commit data... | |
progress.scss | Loading commit data... | |
selects.scss | Loading commit data... | |
sidebar.scss | Loading commit data... | |
tables.scss | Loading commit data... | |
timeline.scss | Loading commit data... | |
tw_bootstrap.scss | Loading commit data... | |
tw_bootstrap_variables.scss | Loading commit data... | |
typography.scss | Loading commit data... | |
variables.scss | Loading commit data... | |
zen.scss | Loading commit data... |