BigW Consortium Gitlab
Support configurable attachment size in Application Settings page ### What does this MR do? This MR provides the ability to configure the maximum size of an attachment inside a note. A parameter has been added to the Application Settings page. ### Are there points in the code the reviewer needs to double check? What should be done with the legacy note attachment validation? I added code to make the validation work with the configurable setting. I could see an issue where an admin lowers the limit from 10 megabytes to 5 megabytes, which could cause an existing model to be invalid. ### Why was this MR needed? We often have attachments that exceed 10 MB, and it would be nice to be able to override the defaults. ### What are the relevant issue numbers / [Feature requests](http://feedback.gitlab.com/)? See Issue #1258 ### Screenshots Before: ![Screen_Shot_2015-03-29_at_3.06.53_PM](https://gitlab.com/gitlab-org/gitlab-ce/uploads/6013a1dbc8cf61a63e93744149937fa0/Screen_Shot_2015-03-29_at_3.06.53_PM.png) After: ![Screen_Shot_2015-03-29_at_3.12.34_PM](https://gitlab.com/gitlab-org/gitlab-ce/uploads/f3518af7e8653ba40f0a3579456da6ad/Screen_Shot_2015-03-29_at_3.12.34_PM.png) See merge request !407
Name |
Last commit
|
Last update |
---|---|---|
.. | ||
1_settings.rb | Loading commit data... | |
2_app.rb | Loading commit data... | |
3_grit_ext.rb | Loading commit data... | |
4_sidekiq.rb | Loading commit data... | |
5_backend.rb | Loading commit data... | |
6_rack_profiler.rb | Loading commit data... | |
7_omniauth.rb | Loading commit data... | |
backtrace_silencers.rb | Loading commit data... | |
carrierwave.rb | Loading commit data... | |
devise.rb | Loading commit data... | |
devise_async.rb | Loading commit data... | |
devise_password_length.rb.example | Loading commit data... | |
disable_email_interceptor.rb | Loading commit data... | |
doorkeeper.rb | Loading commit data... | |
gitlab_shell_secret_token.rb | Loading commit data... | |
haml.rb | Loading commit data... | |
inflections.rb | Loading commit data... | |
kaminari_config.rb | Loading commit data... | |
mime_types.rb | Loading commit data... | |
postgresql_limit_fix.rb | Loading commit data... | |
public_key.rb | Loading commit data... | |
rack_attack.rb.example | Loading commit data... | |
rack_attack_git_basic_auth.rb | Loading commit data... | |
redis-store-fix-expiry.rb | Loading commit data... | |
secret_token.rb | Loading commit data... | |
session_store.rb | Loading commit data... | |
smtp_settings.rb.sample | Loading commit data... | |
state_machine_patch.rb | Loading commit data... | |
static_files.rb | Loading commit data... | |
time_zone.rb | Loading commit data... | |
wrap_parameters.rb | Loading commit data... |