BigW Consortium Gitlab
Fix wiki linking behavior for markdown wiki pages Related to #18019 - As per the documentation in !4372 ## TODO - [ ] !4432 Have wiki linking behave as per the documentation - [x] Move `WikiLinkFilter` specs to the pipeline level - [x] Verify current behavior on wiki `show` page - [x] Fix current behavior on wiki `show` page - [x] Verify current behaviour on wiki preview - [x] Fix current behaviour on wiki preview - [x] Rewrite all links and get preview links working - [x] Make sure all links are on-par with the wiki `show` page - [x] TDD `WikiLinkFilter` and get it working - [x] Hook `WikiLinkFilter` up - [x] Fix tests - [x] Fix `markdown_spec` - [x] Fix `wiki` spinach feature - [x] Wait for [build](https://gitlab.com/gitlab-org/gitlab-ce/commit/4f50dd2/builds) to pass - [x] Make sure all wiki-related pages are working as expected (history, all pages, etc.) - [x] Test in different ruby versions - [x] GitLab instances hosted on a relative URL - [x] Non-markdown rendering formats? - [x] RDoc - [x] ASCIIDoc - [x] Create issues to fix things for RDoc and ASCIIDoc - [x] Gauge performance impact - [x] Refactor - [x] Re-organize commits - [x] Make sure [build](https://gitlab.com/gitlab-org/gitlab-ce/commit/f860e9a8dcabe7d5f160c32fc549807c98baa4a1/builds) passes - [x] Respond to @rymai's comments - [x] `class WikiLinkFilter < HTML::Pipeline::Filter` - [x] blank line after guard clause - [x] keyword arguments for `wiki` and `slug` - [x] invert the condition - [x] inline `user` in spec - [x] Make sure spec names are not out of date - [x] Comment for each rewrite rule - [x] Add CHANGELOG entry - [x] Reorganize commits - [x] Make sure [build](https://gitlab.com/gitlab-org/gitlab-ce/commit/19b91e749a6320d12fb299d33f1f6440777e0e26/builds) passes - [ ] Wait for merge See merge request !4432
Name |
Last commit
|
Last update |
---|---|---|
.. | ||
api | Loading commit data... | |
gitlab_stubs | Loading commit data... | |
matchers | Loading commit data... | |
api_helpers.rb | Loading commit data... | |
capybara.rb | Loading commit data... | |
capybara_helpers.rb | Loading commit data... | |
carrierwave.rb | Loading commit data... | |
db_cleaner.rb | Loading commit data... | |
email_format_shared_examples.rb | Loading commit data... | |
email_helpers.rb | Loading commit data... | |
factory_girl.rb | Loading commit data... | |
fake_u2f_device.rb | Loading commit data... | |
filter_spec_helper.rb | Loading commit data... | |
fixture_helpers.rb | Loading commit data... | |
issue_tracker_service_shared_example.rb | Loading commit data... | |
jira_service_helper.rb | Loading commit data... | |
login_helpers.rb | Loading commit data... | |
markdown_feature.rb | Loading commit data... | |
mentionable_shared_examples.rb | Loading commit data... | |
project_hook_data_shared_example.rb | Loading commit data... | |
reference_parser_helpers.rb | Loading commit data... | |
relative_url.rb | Loading commit data... | |
repo_helpers.rb | Loading commit data... | |
select2_helper.rb | Loading commit data... | |
services_shared_context.rb | Loading commit data... | |
setup_builds_storage.rb | Loading commit data... | |
stub_configuration.rb | Loading commit data... | |
stub_gitlab_calls.rb | Loading commit data... | |
stub_gitlab_data.rb | Loading commit data... | |
taskable_shared_examples.rb | Loading commit data... | |
test_env.rb | Loading commit data... | |
wait_for_ajax.rb | Loading commit data... | |
webmock.rb | Loading commit data... | |
workhorse_helpers.rb | Loading commit data... |