BigW Consortium Gitlab
Defer saving project services to the database if there are no user changes ## What does this MR do? It defers saving project services to the database as long as it is possible. It creates a project service when creating a project only if this project service has an active template. After that project services are saved on the first edit. ## Are there points in the code the reviewer needs to double check? - tests that used `build_missing_services` before the change - number of queries executed ## Why was this MR needed? Motivation in #22281 ## Does this MR meet the acceptance criteria? - [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - Tests - [x] Added for this feature/bug - [x] All builds are passing - [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html) - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if it does - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) ## What are the relevant issue numbers? Fixes #22281 See merge request !6958
Name |
Last commit
|
Last update |
---|---|---|
.. | ||
access_requests_spec.rb | Loading commit data... | |
api_helpers_spec.rb | Loading commit data... | |
award_emoji_spec.rb | Loading commit data... | |
boards_spec.rb | Loading commit data... | |
branches_spec.rb | Loading commit data... | |
broadcast_messages_spec.rb | Loading commit data... | |
builds_spec.rb | Loading commit data... | |
commit_statuses_spec.rb | Loading commit data... | |
commits_spec.rb | Loading commit data... | |
deploy_keys_spec.rb | Loading commit data... | |
deployments_spec.rb | Loading commit data... | |
doorkeeper_access_spec.rb | Loading commit data... | |
environments_spec.rb | Loading commit data... | |
files_spec.rb | Loading commit data... | |
fork_spec.rb | Loading commit data... | |
groups_spec.rb | Loading commit data... | |
internal_spec.rb | Loading commit data... | |
issues_spec.rb | Loading commit data... | |
keys_spec.rb | Loading commit data... | |
labels_spec.rb | Loading commit data... | |
lint_spec.rb | Loading commit data... | |
members_spec.rb | Loading commit data... | |
merge_request_diffs_spec.rb | Loading commit data... | |
merge_requests_spec.rb | Loading commit data... | |
milestones_spec.rb | Loading commit data... | |
namespaces_spec.rb | Loading commit data... | |
notes_spec.rb | Loading commit data... | |
notification_settings_spec.rb | Loading commit data... | |
oauth_tokens_spec.rb | Loading commit data... | |
pipelines_spec.rb | Loading commit data... | |
project_hooks_spec.rb | Loading commit data... | |
project_snippets_spec.rb | Loading commit data... | |
projects_spec.rb | Loading commit data... | |
repositories_spec.rb | Loading commit data... | |
runners_spec.rb | Loading commit data... | |
services_spec.rb | Loading commit data... | |
session_spec.rb | Loading commit data... | |
settings_spec.rb | Loading commit data... | |
sidekiq_metrics_spec.rb | Loading commit data... | |
system_hooks_spec.rb | Loading commit data... | |
tags_spec.rb | Loading commit data... | |
templates_spec.rb | Loading commit data... | |
todos_spec.rb | Loading commit data... | |
triggers_spec.rb | Loading commit data... | |
users_spec.rb | Loading commit data... | |
variables_spec.rb | Loading commit data... | |
version_spec.rb | Loading commit data... |