BigW Consortium Gitlab
Remove pinTo from Flash ## What does this MR do? - replace `pinTo` of `Flash` by `parent` parameter in constructor - move positioning of layout containers from CoffeeScript to layout files - adjust styling of inline flash messages ## Are there points in the code the reviewer needs to double check? - display of flash messages in general ## Why was this MR needed? - allow finding and positioning flash message containers within layout files - allow adding different CSS classes to flash containers within layout files (necessary for fixing #18908) - allow multiple flash messages to be displayed at different places at the same time - make inline flash messages look nicer ## What are the relevant issue numbers? closes #18908, closes part of #18897 ## Screenshots ### Inline flash message (before) ![before](/uploads/c5b3cc05140eaeb9d14e481fa506ebbf/before.png) ![before-mobile](/uploads/004b1f2b9510bd97f4f8a7a6e56f17ef/before-mobile.png) ### Inline flash message (after) ![inline-flash-message](/uploads/fe2a23b63623612b696d529e81fa459e/inline-flash-message.png) ![inline-flash-mobile](/uploads/6207604acfebcf7402d77d5638c89ca8/inline-flash-mobile.png) ### Other flash messages (after) ![flash-message-issue](/uploads/d7e12bd0da68cfa333471ed102428cec/flash-message-issue.png) --- ![flash-new-project](/uploads/3465967dba83296068f154f149d26f64/flash-new-project.png) --- ![flash-sign-in](/uploads/4a5b317d5a369034f43343031607a0c2/flash-sign-in.png) --- ![flash-file-comment](/uploads/488a1119374be7e2173c0a590cfd8821/flash-file-comment.png) --- ![flash-fork](/uploads/f41964e8b910801e03eef3d7649e5009/flash-fork.png) --- ![flash-update-profile](/uploads/9fd972d6c6609fbbf86afcd99d343b5f/flash-update-profile.png) --- ### This is possible now ![flashs-everywhere](/uploads/07f425534511fb4ecaa1d7e2a9870787/flashs-everywhere.png) See merge request !4854
Name |
Last commit
|
Last update |
---|---|---|
.. | ||
behaviors | Loading commit data... | |
blob | Loading commit data... | |
commit | Loading commit data... | |
extensions | Loading commit data... | |
graphs | Loading commit data... | |
lib | Loading commit data... | |
network | Loading commit data... | |
profile | Loading commit data... | |
u2f | Loading commit data... | |
users | Loading commit data... | |
LabelManager.js.coffee | Loading commit data... | |
activities.js.coffee | Loading commit data... | |
admin.js.coffee | Loading commit data... | |
api.js.coffee | Loading commit data... | |
application.js.coffee | Loading commit data... | |
aside.js.coffee | Loading commit data... | |
autosave.js.coffee | Loading commit data... | |
awards_handler.coffee | Loading commit data... | |
breakpoints.coffee | Loading commit data... | |
broadcast_message.js.coffee | Loading commit data... | |
build.coffee | Loading commit data... | |
build_artifacts.js.coffee | Loading commit data... | |
commit.js.coffee | Loading commit data... | |
commits.js.coffee | Loading commit data... | |
compare.js.coffee | Loading commit data... | |
confirm_danger_modal.js.coffee | Loading commit data... | |
copy_to_clipboard.js.coffee | Loading commit data... | |
diff.js.coffee | Loading commit data... | |
dispatcher.js.coffee | Loading commit data... | |
dropzone_input.js.coffee | Loading commit data... | |
due_date_select.js.coffee | Loading commit data... | |
flash.js.coffee | Loading commit data... | |
gfm_auto_complete.js.coffee | Loading commit data... | |
gl_dropdown.js.coffee | Loading commit data... | |
gl_form.js.coffee | Loading commit data... | |
group_avatar.js.coffee | Loading commit data... | |
groups.js.coffee | Loading commit data... | |
groups_select.js.coffee | Loading commit data... | |
importer_status.js.coffee | Loading commit data... | |
issuable.js.coffee | Loading commit data... | |
issuable_context.js.coffee | Loading commit data... | |
issuable_form.js.coffee | Loading commit data... | |
issue.js.coffee | Loading commit data... | |
issue_status_select.js.coffee | Loading commit data... | |
issues-bulk-assignment.js.coffee | Loading commit data... | |
labels.js.coffee | Loading commit data... | |
labels_select.js.coffee | Loading commit data... | |
layout_nav.js.coffee | Loading commit data... | |
line_highlighter.js.coffee | Loading commit data... | |
logo.js.coffee | Loading commit data... | |
markdown_preview.js.coffee | Loading commit data... | |
merge_request.js.coffee | Loading commit data... | |
merge_request_tabs.js.coffee | Loading commit data... | |
merge_request_widget.js.coffee | Loading commit data... | |
merged_buttons.js.coffee | Loading commit data... | |
milestone.js.coffee | Loading commit data... | |
milestone_select.js.coffee | Loading commit data... | |
namespace_select.js.coffee | Loading commit data... | |
new_branch_form.js.coffee | Loading commit data... | |
new_commit_form.js.coffee | Loading commit data... | |
notes.js.coffee | Loading commit data... | |
notifications_dropdown.js.coffee | Loading commit data... | |
notifications_form.js.coffee | Loading commit data... | |
pager.js.coffee | Loading commit data... | |
project.js.coffee | Loading commit data... | |
project_avatar.js.coffee | Loading commit data... | |
project_find_file.js.coffee | Loading commit data... | |
project_fork.js.coffee | Loading commit data... | |
project_import.js.coffee | Loading commit data... | |
project_members.js.coffee | Loading commit data... | |
project_new.js.coffee | Loading commit data... | |
project_select.js.coffee | Loading commit data... | |
project_show.js.coffee | Loading commit data... | |
projects_list.js.coffee | Loading commit data... | |
protected_branch_select.js.coffee | Loading commit data... | |
protected_branches.js.coffee | Loading commit data... | |
right_sidebar.js.coffee | Loading commit data... | |
search.js.coffee | Loading commit data... | |
search_autocomplete.js.coffee | Loading commit data... | |
shortcuts.js.coffee | Loading commit data... | |
shortcuts_blob.coffee | Loading commit data... | |
shortcuts_dashboard_navigation.js.coffee | Loading commit data... | |
shortcuts_find_file.js.coffee | Loading commit data... | |
shortcuts_issuable.coffee | Loading commit data... | |
shortcuts_navigation.coffee | Loading commit data... | |
shortcuts_network.js.coffee | Loading commit data... | |
sidebar.js.coffee | Loading commit data... | |
single_file_diff.js.coffee | Loading commit data... | |
star.js.coffee | Loading commit data... | |
subscription.js.coffee | Loading commit data... | |
syntax_highlight.coffee | Loading commit data... | |
todos.js.coffee | Loading commit data... | |
tree.js.coffee | Loading commit data... | |
user.js.coffee | Loading commit data... | |
user_tabs.js.coffee | Loading commit data... | |
users_select.js.coffee | Loading commit data... | |
wikis.js.coffee | Loading commit data... | |
zen_mode.js.coffee | Loading commit data... |