Name |
Last commit
|
Last update |
---|---|---|
.. | ||
_builds.html.haml | ||
_commits.html.haml | ||
_diffs.html.haml | ||
_how_to_merge.html.haml | ||
_mr_box.html.haml | ||
_mr_title.html.haml | ||
_pipelines.html.haml |
BigW Consortium Gitlab
Fix button missing type ## What does this MR do? Adds the `type` attribute to `<button>` ## Are there points in the code the reviewer needs to double check? Shouldn't be ## Why was this MR needed? So that bootlint would stop giving warnings on the issue thread page and the merge request thread page ## What are the relevant issue numbers? #20715 ## Does this MR meet the acceptance criteria? - [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - Tests - [x] All builds are passing - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if you do - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) See merge request !5718
Name |
Last commit
|
Last update |
---|---|---|
.. | ||
_builds.html.haml | Loading commit data... | |
_commits.html.haml | Loading commit data... | |
_diffs.html.haml | Loading commit data... | |
_how_to_merge.html.haml | Loading commit data... | |
_mr_box.html.haml | Loading commit data... | |
_mr_title.html.haml | Loading commit data... | |
_pipelines.html.haml | Loading commit data... |