BigW Consortium Gitlab
Resolve "Introduce round-robin project creation to spread load over multiple shards" ## What does this MR do? Allow multiple shards to be enabled in the admin settings page, balancing project creation across all enabled shards. ## Are there points in the code the reviewer needs to double check? * `f.select ..., multiple: true` isn't the most beautiful UI in the world, but switching to `collection_check_boxes` (or a facsimile thereof) isn't trivial * Should `pick_repository_storage` be a method of `ApplicationSetting`, or `Project`? It's going to accrete logic over time so perhaps it should be its own class already? * This is written to avoid the need for a database migration, so it is`serialize :repository_storage` without `, Array`. This is tested, but alternatives include: * Add a database migration * Write a custom Coder that will accept a String or Array in `load` and always `dump an Array. ## Why was this MR needed? ## Screenshots (if relevant) ![Screen_Shot_2016-11-03_at_14.42.41](/uploads/7de15d6c1b3fa60bb7a34d6a7d9f00ce/Screen_Shot_2016-11-03_at_14.42.41.png) ## Does this MR meet the acceptance criteria? - [X] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG.md) entry added - [X] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - [x] API support added - Tests - [X] Added for this feature/bug - [ ] All builds are passing - [X] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html) - [X] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [X] Branch has no merge conflicts with `master` (if it does - rebase it please) - [X] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) ## What are the relevant issue numbers? Closes #24059 See merge request !7273
Name |
Last commit
|
Last update |
---|---|---|
.. | ||
access_requests_spec.rb | Loading commit data... | |
api_helpers_spec.rb | Loading commit data... | |
award_emoji_spec.rb | Loading commit data... | |
boards_spec.rb | Loading commit data... | |
branches_spec.rb | Loading commit data... | |
broadcast_messages_spec.rb | Loading commit data... | |
builds_spec.rb | Loading commit data... | |
commit_statuses_spec.rb | Loading commit data... | |
commits_spec.rb | Loading commit data... | |
deploy_keys_spec.rb | Loading commit data... | |
deployments_spec.rb | Loading commit data... | |
doorkeeper_access_spec.rb | Loading commit data... | |
environments_spec.rb | Loading commit data... | |
files_spec.rb | Loading commit data... | |
fork_spec.rb | Loading commit data... | |
groups_spec.rb | Loading commit data... | |
internal_spec.rb | Loading commit data... | |
issues_spec.rb | Loading commit data... | |
keys_spec.rb | Loading commit data... | |
labels_spec.rb | Loading commit data... | |
lint_spec.rb | Loading commit data... | |
members_spec.rb | Loading commit data... | |
merge_request_diffs_spec.rb | Loading commit data... | |
merge_requests_spec.rb | Loading commit data... | |
milestones_spec.rb | Loading commit data... | |
namespaces_spec.rb | Loading commit data... | |
notes_spec.rb | Loading commit data... | |
notification_settings_spec.rb | Loading commit data... | |
oauth_tokens_spec.rb | Loading commit data... | |
pipelines_spec.rb | Loading commit data... | |
project_hooks_spec.rb | Loading commit data... | |
project_snippets_spec.rb | Loading commit data... | |
projects_spec.rb | Loading commit data... | |
repositories_spec.rb | Loading commit data... | |
runners_spec.rb | Loading commit data... | |
services_spec.rb | Loading commit data... | |
session_spec.rb | Loading commit data... | |
settings_spec.rb | Loading commit data... | |
sidekiq_metrics_spec.rb | Loading commit data... | |
system_hooks_spec.rb | Loading commit data... | |
tags_spec.rb | Loading commit data... | |
templates_spec.rb | Loading commit data... | |
todos_spec.rb | Loading commit data... | |
triggers_spec.rb | Loading commit data... | |
users_spec.rb | Loading commit data... | |
variables_spec.rb | Loading commit data... | |
version_spec.rb | Loading commit data... |