BigW Consortium Gitlab
- Previously, we sorted commits by date, which seemed to work okay. - The one edge case where this failed was when multiple commits have the same commit date (for example: when a range of commits are cherry picked with a single command, they all have the same commit date [and different author dates]). - Commits with the same commit date would be sorted arbitrarily, and usually break the network graph. - This commit solves the problem by both sorting by date, and by sorting topographically (parents aren't displayed until all their children are displayed) - Include review comments from @adamniedzielski A more detailed explanation is present here: https://gitlab.com/gitlab-org/gitlab-ce/issues/30973#note_28706230
Name |
Last commit
|
Last update |
---|---|---|
.. | ||
bin | Loading commit data... | |
config | Loading commit data... | |
controllers | Loading commit data... | |
db/production | Loading commit data... | |
factories | Loading commit data... | |
features | Loading commit data... | |
finders | Loading commit data... | |
fixtures | Loading commit data... | |
helpers | Loading commit data... | |
initializers | Loading commit data... | |
javascripts | Loading commit data... | |
lib | Loading commit data... | |
mailers | Loading commit data... | |
migrations | Loading commit data... | |
models | Loading commit data... | |
policies | Loading commit data... | |
presenters | Loading commit data... | |
requests | Loading commit data... | |
routing | Loading commit data... | |
rubocop/cop | Loading commit data... | |
serializers | Loading commit data... | |
services | Loading commit data... | |
support | Loading commit data... | |
tasks | Loading commit data... | |
unicorn | Loading commit data... | |
uploaders | Loading commit data... | |
validators | Loading commit data... | |
views | Loading commit data... | |
workers | Loading commit data... | |
factories_spec.rb | Loading commit data... | |
rails_helper.rb | Loading commit data... | |
rake_helper.rb | Loading commit data... | |
simplecov_env.rb | Loading commit data... | |
spec_helper.rb | Loading commit data... |