BigW Consortium Gitlab
In Rails 4.2.10 the `ActiveSupport::TimeZone.find_tzinfo(timezone_name)` method calls `TZInfo::TimezoneProxy.new(timezone_name)` which returns `timezone_name` if it is invalid. But in Rails 5.0 the `ActiveSupport::TimeZone.find_tzinfo(timezone_name)` method now calls the `TZInfo::Timezone.new(timezone_name)` method which throws the `TZInfo::InvalidTimezoneIdentifier: Invalid identifier` exception if `timezone_name` is invalid. This commit adds the rescue block to return timezone name if the exception is raised. Also this change fixes the error: ``` 1) Ci::PipelineSchedule validations does not allow invalid cron patters Failure/Error: ActiveSupport::TimeZone.find_tzinfo(timezone).name TZInfo::InvalidTimezoneIdentifier: Invalid identifier # ./lib/gitlab/ci/cron_parser.rb:28:in `timezone_name' # ./lib/gitlab/ci/cron_parser.rb:9:in `initialize' # ./app/validators/cron_validator.rb:6:in `new' # ./app/validators/cron_validator.rb:6:in `validate_each' # ./spec/models/ci/pipeline_schedule_spec.rb:26:in `block (3 levels) in <top (required)>' ```
Name |
Last commit
|
Last update |
---|---|---|
.. | ||
api | Loading commit data... | |
assets | Loading commit data... | |
backup | Loading commit data... | |
banzai | Loading commit data... | |
bitbucket | Loading commit data... | |
constraints | Loading commit data... | |
container_registry | Loading commit data... | |
declarative_policy | Loading commit data... | |
generators/rails/post_deployment_migration | Loading commit data... | |
gitaly | Loading commit data... | |
gitlab | Loading commit data... | |
google_api | Loading commit data... | |
haml_lint | Loading commit data... | |
json_web_token | Loading commit data... | |
mattermost | Loading commit data... | |
microsoft_teams | Loading commit data... | |
omni_auth/strategies | Loading commit data... | |
peek | Loading commit data... | |
rouge | Loading commit data... | |
rspec_flaky | Loading commit data... | |
support | Loading commit data... | |
system_check | Loading commit data... | |
tasks | Loading commit data... | |
additional_email_headers_interceptor.rb | Loading commit data... | |
after_commit_queue.rb | Loading commit data... | |
banzai.rb | Loading commit data... | |
carrier_wave_string_file.rb | Loading commit data... | |
declarative_policy.rb | Loading commit data... | |
disable_email_interceptor.rb | Loading commit data... | |
email_template_interceptor.rb | Loading commit data... | |
event_filter.rb | Loading commit data... | |
expand_variables.rb | Loading commit data... | |
extracts_path.rb | Loading commit data... | |
feature.rb | Loading commit data... | |
file_size_validator.rb | Loading commit data... | |
forever.rb | Loading commit data... | |
gitlab.rb | Loading commit data... | |
gt_one_coercion.rb | Loading commit data... | |
milestone_array.rb | Loading commit data... | |
static_model.rb | Loading commit data... | |
system_check.rb | Loading commit data... | |
unfold_form.rb | Loading commit data... | |
uploaded_file.rb | Loading commit data... | |
version_check.rb | Loading commit data... |