BigW Consortium Gitlab
The issue was with the `User#groups` and `User#projects` associations
which goes through the `User#group_members` and `User#project_members`.
Initially I chose to use a secure approach by storing the requester's
user ID in `Member#created_by_id` instead of `Member#user_id` because I
was aware that there was a security risk since I didn't know the
codebase well enough.
Then during the review, we decided to change that and directly store the
requester's user ID into `Member#user_id` (for the sake of simplifying
the code I believe), meaning that every `group_members` / `project_members`
association would include the requesters by default...
My bad for not checking that all the `group_members` / `project_members`
associations and the ones that go through them (e.g. `Group#users` and
`Project#users`) were made safe with the `where(requested_at: nil)` /
`where(members: { requested_at: nil })` scopes.
Now they are all secure.
Signed-off-by: Rémy Coutable <remy@rymai.me>
Name |
Last commit
|
Last update |
---|---|---|
.. | ||
admin | Loading commit data... | |
ci | Loading commit data... | |
concerns | Loading commit data... | |
dashboard | Loading commit data... | |
explore | Loading commit data... | |
groups | Loading commit data... | |
import | Loading commit data... | |
oauth | Loading commit data... | |
profiles | Loading commit data... | |
projects | Loading commit data... | |
sherlock | Loading commit data... | |
abuse_reports_controller.rb | Loading commit data... | |
application_controller.rb | Loading commit data... | |
autocomplete_controller.rb | Loading commit data... | |
confirmations_controller.rb | Loading commit data... | |
dashboard_controller.rb | Loading commit data... | |
emojis_controller.rb | Loading commit data... | |
groups_controller.rb | Loading commit data... | |
health_check_controller.rb | Loading commit data... | |
help_controller.rb | Loading commit data... | |
invites_controller.rb | Loading commit data... | |
jwt_controller.rb | Loading commit data... | |
namespaces_controller.rb | Loading commit data... | |
notification_settings_controller.rb | Loading commit data... | |
omniauth_callbacks_controller.rb | Loading commit data... | |
passwords_controller.rb | Loading commit data... | |
profiles_controller.rb | Loading commit data... | |
projects_controller.rb | Loading commit data... | |
registrations_controller.rb | Loading commit data... | |
root_controller.rb | Loading commit data... | |
search_controller.rb | Loading commit data... | |
sent_notifications_controller.rb | Loading commit data... | |
sessions_controller.rb | Loading commit data... | |
snippets_controller.rb | Loading commit data... | |
uploads_controller.rb | Loading commit data... | |
users_controller.rb | Loading commit data... |