BigW Consortium Gitlab
1. It makes sense to reuse these constants since we had them duplicated in the previous enum implementation. This also simplifies our `check_access` implementation, because we can use `project.team.max_member_access` directly. 2. Use `accepts_nested_attributes_for` to create push/merge access levels. This was a bit fiddly to set up, but this simplifies our code by quite a large amount. We can even get rid of `ProtectedBranches::BaseService`. 3. Move API handling back into the API (previously in `ProtectedBranches::BaseService#translate_api_params`. 4. The protected branch services now return a `ProtectedBranch` rather than `true/false`. 5. Run `load_protected_branches` on-demand in the `create` action, to prevent it being called unneccessarily. 6. "Masters" is pre-selected as the default option for "Allowed to Push" and "Allowed to Merge". 7. These changes were based on a review from @rymai in !5081.
Name |
Last commit
|
Last update |
---|---|---|
.. | ||
application_controller.rb | Loading commit data... | |
artifacts_controller.rb | Loading commit data... | |
avatars_controller.rb | Loading commit data... | |
badges_controller.rb | Loading commit data... | |
blame_controller.rb | Loading commit data... | |
blob_controller.rb | Loading commit data... | |
branches_controller.rb | Loading commit data... | |
builds_controller.rb | Loading commit data... | |
commit_controller.rb | Loading commit data... | |
commits_controller.rb | Loading commit data... | |
compare_controller.rb | Loading commit data... | |
container_registry_controller.rb | Loading commit data... | |
deploy_keys_controller.rb | Loading commit data... | |
environments_controller.rb | Loading commit data... | |
find_file_controller.rb | Loading commit data... | |
forks_controller.rb | Loading commit data... | |
git_http_controller.rb | Loading commit data... | |
graphs_controller.rb | Loading commit data... | |
group_links_controller.rb | Loading commit data... | |
hooks_controller.rb | Loading commit data... | |
imports_controller.rb | Loading commit data... | |
issues_controller.rb | Loading commit data... | |
labels_controller.rb | Loading commit data... | |
merge_requests_controller.rb | Loading commit data... | |
milestones_controller.rb | Loading commit data... | |
network_controller.rb | Loading commit data... | |
notes_controller.rb | Loading commit data... | |
pipelines_controller.rb | Loading commit data... | |
pipelines_settings_controller.rb | Loading commit data... | |
project_members_controller.rb | Loading commit data... | |
protected_branches_controller.rb | Loading commit data... | |
raw_controller.rb | Loading commit data... | |
refs_controller.rb | Loading commit data... | |
releases_controller.rb | Loading commit data... | |
repositories_controller.rb | Loading commit data... | |
runner_projects_controller.rb | Loading commit data... | |
runners_controller.rb | Loading commit data... | |
services_controller.rb | Loading commit data... | |
snippets_controller.rb | Loading commit data... | |
tags_controller.rb | Loading commit data... | |
todos_controller.rb | Loading commit data... | |
tree_controller.rb | Loading commit data... | |
triggers_controller.rb | Loading commit data... | |
uploads_controller.rb | Loading commit data... | |
variables_controller.rb | Loading commit data... | |
wikis_controller.rb | Loading commit data... |