BigW Consortium Gitlab
Resolve "Create a tab shortcut to jump directly to content" ## What does this MR do? Adds accessibility shortcut to page, i.e. if user hits `tab` key right after the page is loaded and user has not interacted to any part of the page, the shortcut appears at top left corner of the page. Then, pressing `enter` (`spacebar` support is WIP) scrolls page to focus on content. ## Are there points in the code the reviewer needs to double check? See if `id` attribute added to `.content` element (present in [_page.html.haml](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/app/views/layouts/_page.html.haml)) needs to be reviewed if it is correct approach or we already have an ID that shortcut can refer to. ## Why was this MR needed? This feature is particularly useful for screen readers where user doesn't have to go through entire nav to reach content of page. ## Screenshots (if relevant) ![Screenshot_from_2016-11-17_17-59-22](/uploads/0eb0149f46bd35e9ce629e7a6533be53/Screenshot_from_2016-11-17_17-59-22.png) ## Does this MR meet the acceptance criteria? - [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added - [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - [ ] API support added - Tests - [ ] Added for this feature/bug - [ ] All builds are passing - [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html) - [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [ ] Branch has no merge conflicts with `master` (if it does - rebase it please) - [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) ## What are the relevant issue numbers? Closes #24057 See merge request !7533
Name |
Last commit
|
Last update |
---|---|---|
.. | ||
abuse_report_mailer | Loading commit data... | |
abuse_reports | Loading commit data... | |
admin | Loading commit data... | |
award_emoji | Loading commit data... | |
ci/lints | Loading commit data... | |
dashboard | Loading commit data... | |
devise | Loading commit data... | |
discussions | Loading commit data... | |
doorkeeper | Loading commit data... | |
email_rejection_mailer | Loading commit data... | |
emojis | Loading commit data... | |
errors | Loading commit data... | |
events | Loading commit data... | |
explore | Loading commit data... | |
groups | Loading commit data... | |
help | Loading commit data... | |
import | Loading commit data... | |
invites | Loading commit data... | |
issues | Loading commit data... | |
kaminari/gitlab | Loading commit data... | |
koding | Loading commit data... | |
layouts | Loading commit data... | |
notify | Loading commit data... | |
profiles | Loading commit data... | |
projects | Loading commit data... | |
repository_check_mailer | Loading commit data... | |
search | Loading commit data... | |
sent_notifications | Loading commit data... | |
shared | Loading commit data... | |
sherlock | Loading commit data... | |
snippets | Loading commit data... | |
u2f | Loading commit data... | |
users | Loading commit data... |