BigW Consortium Gitlab
Fix bug where destroying a namespace would not always destroy projects There is a race condition in DestroyGroupService now that projects are deleted asynchronously: 1. User attempts to delete group 2. DestroyGroupService iterates through all projects and schedules a Sidekiq job to delete each Project 3. DestroyGroupService destroys the Group, leaving all its projects without a namespace 4. Projects::DestroyService runs later but the can?(current_user, :remove_project) is `false` because the user no longer has permission to destroy projects with no namespace. 5. This leaves the project in pending_delete state with no namespace/group. Projects without a namespace or group also adds another problem: it's not possible to destroy the container registry tags, since `container_registry_path_with_namespace` is the wrong value. The fix is to destroy the group asynchronously and run `execute` directly on Projects::DestroyService. Closes #17893 See merge request !4341
Name |
Last commit
|
Last update |
---|---|---|
.. | ||
access_requests_spec.rb | Loading commit data... | |
api_helpers_spec.rb | Loading commit data... | |
award_emoji_spec.rb | Loading commit data... | |
branches_spec.rb | Loading commit data... | |
builds_spec.rb | Loading commit data... | |
commit_statuses_spec.rb | Loading commit data... | |
commits_spec.rb | Loading commit data... | |
deploy_keys_spec.rb | Loading commit data... | |
doorkeeper_access_spec.rb | Loading commit data... | |
environments_spec.rb | Loading commit data... | |
files_spec.rb | Loading commit data... | |
fork_spec.rb | Loading commit data... | |
groups_spec.rb | Loading commit data... | |
internal_spec.rb | Loading commit data... | |
issues_spec.rb | Loading commit data... | |
keys_spec.rb | Loading commit data... | |
labels_spec.rb | Loading commit data... | |
license_templates_spec.rb | Loading commit data... | |
members_spec.rb | Loading commit data... | |
merge_requests_spec.rb | Loading commit data... | |
milestones_spec.rb | Loading commit data... | |
namespaces_spec.rb | Loading commit data... | |
notes_spec.rb | Loading commit data... | |
project_hooks_spec.rb | Loading commit data... | |
project_snippets_spec.rb | Loading commit data... | |
projects_spec.rb | Loading commit data... | |
repositories_spec.rb | Loading commit data... | |
runners_spec.rb | Loading commit data... | |
services_spec.rb | Loading commit data... | |
session_spec.rb | Loading commit data... | |
settings_spec.rb | Loading commit data... | |
sidekiq_metrics_spec.rb | Loading commit data... | |
system_hooks_spec.rb | Loading commit data... | |
tags_spec.rb | Loading commit data... | |
templates_spec.rb | Loading commit data... | |
todos_spec.rb | Loading commit data... | |
triggers_spec.rb | Loading commit data... | |
users_spec.rb | Loading commit data... | |
variables_spec.rb | Loading commit data... |