BigW Consortium Gitlab
Original Comments ================= - Linking behaves as per rules documented here: https://gitlab.com/gitlab-org/gitlab-ce/blob/16568-document-wiki-linking-behavior/doc/markdown/wiki.md - All links (to other wiki pages) are rewritten to be at the level of the app root. We can't use links relative to the current page ('./foo', 'foo', '../foo'), because they won't work in the markdown preview, where the current page is suffixed with `/edit` - Move existing `WikiLinkFilter` specs to `WikiPipeline` spec. It makes sense to run these tests on the combined output of the pipeline, rather than a single filter, since we can catch issues with conflicting filters. - Add more tests to cover the new linking @rymai's Review =============== - Classes nested under `WikiLinkFilter` should declare `WikiLinkFilter`'s inherit, so nothing changes if the nested class is loaded first. - Add a blank line after a guard clause - Use keyword arguments for the `Rewriter` constructor - Invert a condition - use `if` instead of `unless` - Inline a `let` in `WikiPipeline` spec - it was only used in a single place - Change out of date spec names - Add a comment for every rewrite rule in `Rewriter`
Name |
Last commit
|
Last update |
---|---|---|
.. | ||
wiki_link_filter | Loading commit data... | |
abstract_reference_filter.rb | Loading commit data... | |
autolink_filter.rb | Loading commit data... | |
commit_range_reference_filter.rb | Loading commit data... | |
commit_reference_filter.rb | Loading commit data... | |
emoji_filter.rb | Loading commit data... | |
external_issue_reference_filter.rb | Loading commit data... | |
external_link_filter.rb | Loading commit data... | |
gollum_tags_filter.rb | Loading commit data... | |
image_link_filter.rb | Loading commit data... | |
inline_diff_filter.rb | Loading commit data... | |
issue_reference_filter.rb | Loading commit data... | |
label_reference_filter.rb | Loading commit data... | |
markdown_filter.rb | Loading commit data... | |
merge_request_reference_filter.rb | Loading commit data... | |
milestone_reference_filter.rb | Loading commit data... | |
redactor_filter.rb | Loading commit data... | |
reference_filter.rb | Loading commit data... | |
relative_link_filter.rb | Loading commit data... | |
sanitization_filter.rb | Loading commit data... | |
snippet_reference_filter.rb | Loading commit data... | |
syntax_highlight_filter.rb | Loading commit data... | |
table_of_contents_filter.rb | Loading commit data... | |
task_list_filter.rb | Loading commit data... | |
upload_link_filter.rb | Loading commit data... | |
user_reference_filter.rb | Loading commit data... | |
wiki_link_filter.rb | Loading commit data... | |
yaml_front_matter_filter.rb | Loading commit data... |