BigW Consortium Gitlab
Memoize Github::Shell's secret token ## What does this MR do? `API::Helpers#secret_token` was reading the secret file on every invocation. This MR reads the file in the `gitlab_shell_secret_token.rb` initializer and saves it as a class variable at `Gitlab::Shell.secret_token` ## Are there points in the code the reviewer needs to double check? - I'm not sure if the use of `cattr_accessor` is the best approach, or if should be moved into the `class << self` block? - Should `API::Helpers#secret_token` be removed in favor of using `Gitlab::Shell.secret_token`? ## Why was this MR needed? Performance optimization. Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/22510 See merge request !6599
Name |
Last commit
|
Last update |
---|---|---|
.. | ||
helpers | Loading commit data... | |
access_requests.rb | Loading commit data... | |
api.rb | Loading commit data... | |
api_guard.rb | Loading commit data... | |
award_emoji.rb | Loading commit data... | |
boards.rb | Loading commit data... | |
branches.rb | Loading commit data... | |
broadcast_messages.rb | Loading commit data... | |
builds.rb | Loading commit data... | |
commit_statuses.rb | Loading commit data... | |
commits.rb | Loading commit data... | |
deploy_keys.rb | Loading commit data... | |
deployments.rb | Loading commit data... | |
entities.rb | Loading commit data... | |
environments.rb | Loading commit data... | |
files.rb | Loading commit data... | |
groups.rb | Loading commit data... | |
helpers.rb | Loading commit data... | |
internal.rb | Loading commit data... | |
issues.rb | Loading commit data... | |
keys.rb | Loading commit data... | |
labels.rb | Loading commit data... | |
license_templates.rb | Loading commit data... | |
lint.rb | Loading commit data... | |
members.rb | Loading commit data... | |
merge_request_diffs.rb | Loading commit data... | |
merge_requests.rb | Loading commit data... | |
milestones.rb | Loading commit data... | |
namespaces.rb | Loading commit data... | |
notes.rb | Loading commit data... | |
notification_settings.rb | Loading commit data... | |
pipelines.rb | Loading commit data... | |
project_hooks.rb | Loading commit data... | |
project_snippets.rb | Loading commit data... | |
projects.rb | Loading commit data... | |
repositories.rb | Loading commit data... | |
runners.rb | Loading commit data... | |
services.rb | Loading commit data... | |
session.rb | Loading commit data... | |
settings.rb | Loading commit data... | |
sidekiq_metrics.rb | Loading commit data... | |
subscriptions.rb | Loading commit data... | |
system_hooks.rb | Loading commit data... | |
tags.rb | Loading commit data... | |
templates.rb | Loading commit data... | |
todos.rb | Loading commit data... | |
triggers.rb | Loading commit data... | |
users.rb | Loading commit data... | |
variables.rb | Loading commit data... |