BigW Consortium Gitlab
1. It makes sense to reuse these constants since we had them duplicated in the previous enum implementation. This also simplifies our `check_access` implementation, because we can use `project.team.max_member_access` directly. 2. Use `accepts_nested_attributes_for` to create push/merge access levels. This was a bit fiddly to set up, but this simplifies our code by quite a large amount. We can even get rid of `ProtectedBranches::BaseService`. 3. Move API handling back into the API (previously in `ProtectedBranches::BaseService#translate_api_params`. 4. The protected branch services now return a `ProtectedBranch` rather than `true/false`. 5. Run `load_protected_branches` on-demand in the `create` action, to prevent it being called unneccessarily. 6. "Masters" is pre-selected as the default option for "Allowed to Push" and "Allowed to Merge". 7. These changes were based on a review from @rymai in !5081.
Name |
Last commit
|
Last update |
---|---|---|
.. | ||
ci | Loading commit data... | |
abuse_reports.rb | Loading commit data... | |
appearances.rb | Loading commit data... | |
award_emoji.rb | Loading commit data... | |
broadcast_messages.rb | Loading commit data... | |
commit_statuses.rb | Loading commit data... | |
commits.rb | Loading commit data... | |
deploy_keys_projects.rb | Loading commit data... | |
deployments.rb | Loading commit data... | |
emails.rb | Loading commit data... | |
environments.rb | Loading commit data... | |
events.rb | Loading commit data... | |
file_uploader.rb | Loading commit data... | |
forked_project_links.rb | Loading commit data... | |
group_members.rb | Loading commit data... | |
groups.rb | Loading commit data... | |
identities.rb | Loading commit data... | |
issues.rb | Loading commit data... | |
keys.rb | Loading commit data... | |
label_links.rb | Loading commit data... | |
labels.rb | Loading commit data... | |
lfs_objects.rb | Loading commit data... | |
lfs_objects_projects.rb | Loading commit data... | |
merge_requests.rb | Loading commit data... | |
milestones.rb | Loading commit data... | |
namespaces.rb | Loading commit data... | |
notes.rb | Loading commit data... | |
notification_settings.rb | Loading commit data... | |
oauth_access_tokens.rb | Loading commit data... | |
oauth_applications.rb | Loading commit data... | |
personal_access_tokens.rb | Loading commit data... | |
personal_snippets.rb | Loading commit data... | |
project_group_links.rb | Loading commit data... | |
project_hooks.rb | Loading commit data... | |
project_members.rb | Loading commit data... | |
project_snippets.rb | Loading commit data... | |
project_wikis.rb | Loading commit data... | |
projects.rb | Loading commit data... | |
protected_branches.rb | Loading commit data... | |
releases.rb | Loading commit data... | |
sent_notifications.rb | Loading commit data... | |
service_hooks.rb | Loading commit data... | |
services.rb | Loading commit data... | |
snippets.rb | Loading commit data... | |
spam_logs.rb | Loading commit data... | |
system_hooks.rb | Loading commit data... | |
todos.rb | Loading commit data... | |
u2f_registrations.rb | Loading commit data... | |
users.rb | Loading commit data... | |
wiki_pages.rb | Loading commit data... |