BigW Consortium Gitlab
Fix inconsistent highlighting of already selected activity nav-links ## What does this MR do? * Remove edge case where user could deselect an activity nav-link (which seems to be returning all the events) * Explicitly add an `All` tab to return all the events ## Are there points in the code the reviewer needs to double check? Shouldn't be ## Why was this MR needed? Resolves existing UI inconsistency ## Screenshots (if relevant) Before: ![4OzkoQVJYc](/uploads/fd2a7fdbde2159e875482ec7b828fe60/4OzkoQVJYc.gif) After: ![E0lj8UhEUU](/uploads/7eb5155861eb79d72957de04c9f172c9/E0lj8UhEUU.gif) ## Does this MR meet the acceptance criteria? - [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - Tests - [x] All builds are passing - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if you do - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) ## What are the relevant issue numbers? * Closes #21631 * Closes #21452 See merge request !6091
Name |
Last commit
|
Last update |
---|---|---|
.. | ||
builds | Loading commit data... | |
groups | Loading commit data... | |
icons | Loading commit data... | |
issuable | Loading commit data... | |
members | Loading commit data... | |
milestones | Loading commit data... | |
notifications | Loading commit data... | |
projects | Loading commit data... | |
snippets | Loading commit data... | |
web_hooks | Loading commit data... | |
_allow_request_access.html.haml | Loading commit data... | |
_choose_group_avatar_button.html.haml | Loading commit data... | |
_clone_panel.html.haml | Loading commit data... | |
_commit_message_container.html.haml | Loading commit data... | |
_confirm_modal.html.haml | Loading commit data... | |
_event_filter.html.haml | Loading commit data... | |
_field.html.haml | Loading commit data... | |
_file_highlight.html.haml | Loading commit data... | |
_group_form.html.haml | Loading commit data... | |
_group_tips.html.haml | Loading commit data... | |
_import_form.html.haml | Loading commit data... | |
_issues.html.haml | Loading commit data... | |
_label_row.html.haml | Loading commit data... | |
_labels_row.html.haml | Loading commit data... | |
_logo.svg | Loading commit data... | |
_merge_requests.html.haml | Loading commit data... | |
_milestone_expired.html.haml | Loading commit data... | |
_milestones_filter.html.haml | Loading commit data... | |
_nav_scroll.html.haml | Loading commit data... | |
_new_commit_form.html.haml | Loading commit data... | |
_new_project_item_select.html.haml | Loading commit data... | |
_no_password.html.haml | Loading commit data... | |
_no_ssh.html.haml | Loading commit data... | |
_outdated_browser.html.haml | Loading commit data... | |
_project_limit.html.haml | Loading commit data... | |
_promo.html.haml | Loading commit data... | |
_ref_switcher.html.haml | Loading commit data... | |
_service_settings.html.haml | Loading commit data... | |
_show_aside.html.haml | Loading commit data... | |
_sort_dropdown.html.haml | Loading commit data... | |
_visibility_level.html.haml | Loading commit data... | |
_visibility_radios.html.haml | Loading commit data... |