BigW Consortium Gitlab
Correct autocomplete for values with special characters ## What does this MR do? This adds a check for any special chars in any value passed to the `DefaultOptions.beforeInsert` callback function. If special chars are found and `skipSpecialCharTest` option is `false`, it will wrap the value in quotation marks. This fixed autocompleting `~customer+` instead of `~"customer+"`. ## Are there points in the code the reviewer needs to double check? ## Why was this MR needed? ## Screenshots (if relevant) ![2016-12-03_10.37.11](/uploads/59159623638939933d23b447692775b8/2016-12-03_10.37.11.gif) ## Does this MR meet the acceptance criteria? - [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added - [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - [ ] API support added - Tests - [ ] Added for this feature/bug - [ ] All builds are passing - [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html) - [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [ ] Branch has no merge conflicts with `master` (if it does - rebase it please) - [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) ## What are the relevant issue numbers? Closes #25286, #24961 See merge request !7910
Name |
Last commit
|
Last update |
---|---|---|
.. | ||
award_emoji_spec.rb | Loading commit data... | |
award_spec.rb | Loading commit data... | |
bulk_assignment_labels_spec.rb | Loading commit data... | |
create_issue_for_discussions_in_merge_request_spec.rb | Loading commit data... | |
filter_by_labels_spec.rb | Loading commit data... | |
filter_by_milestone_spec.rb | Loading commit data... | |
filter_issues_spec.rb | Loading commit data... | |
form_spec.rb | Loading commit data... | |
gfm_autocomplete_spec.rb | Loading commit data... | |
issue_sidebar_spec.rb | Loading commit data... | |
move_spec.rb | Loading commit data... | |
new_branch_button_spec.rb | Loading commit data... | |
note_polling_spec.rb | Loading commit data... | |
reset_filters_spec.rb | Loading commit data... | |
todo_spec.rb | Loading commit data... | |
update_issues_spec.rb | Loading commit data... | |
user_uses_slash_commands_spec.rb | Loading commit data... |