BigW Consortium Gitlab
Fix missing access checks on issue lookup using IssuableFinder Split from !2024 to partially solve https://gitlab.com/gitlab-org/gitlab-ce/issues/23867⚠ - Potentially untested💣 - No test coverage🚥 - Test coverage of some sort exists (a test failed when error raised)🚦 - Test coverage of return value (a test failed when nil used)✅ - Permissions check tested - [x]✅ app/controllers/projects/branches_controller.rb:39 - `before_action :authorize_push_code!` helpes limit/prevent exploitation. Always checks for reporter access so fine with confidential issues, issues only visible to team, etc. - [x]🚥 app/models/cycle_analytics/summary.rb:9 [`.count`] - [x]✅ app/controllers/projects/todos_controller.rb:19 - [x] Potential double render in app/controllers/projects/todos_controller.rb - https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#cedccb227af9bfdf88802767cb58d43c2b977439_24_24 See merge request !2030
Name |
Last commit
|
Last update |
---|---|---|
.. | ||
README.md | Loading commit data... | |
access_requests_finder.rb | Loading commit data... | |
branches_finder.rb | Loading commit data... | |
contributed_projects_finder.rb | Loading commit data... | |
group_projects_finder.rb | Loading commit data... | |
groups_finder.rb | Loading commit data... | |
issuable_finder.rb | Loading commit data... | |
issues_finder.rb | Loading commit data... | |
joined_groups_finder.rb | Loading commit data... | |
labels_finder.rb | Loading commit data... | |
merge_requests_finder.rb | Loading commit data... | |
milestones_finder.rb | Loading commit data... | |
move_to_project_finder.rb | Loading commit data... | |
notes_finder.rb | Loading commit data... | |
personal_projects_finder.rb | Loading commit data... | |
pipelines_finder.rb | Loading commit data... | |
projects_finder.rb | Loading commit data... | |
snippets_finder.rb | Loading commit data... | |
tags_finder.rb | Loading commit data... | |
todos_finder.rb | Loading commit data... | |
union_finder.rb | Loading commit data... |